1600121 - Get rid of check for target path length on target-created

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Andreas Tolfsen ❲:ato❳]

When target-created is handled we check explicitly that it’s URL path is not empty:

    this.targets.on("target-created", (eventName, target) => {
      if (!target.path) {
        throw new Error(`Target is missing 'path' attribute: ${target}`);
      }
      this.server.registerPathHandler(target.path, target);
    });

It should be illegal in nsIHttpServer.registerPathHandler to register a path
on an empty string because it cannot later be accessed or referenced, i.e. deleted.

It also blocks bug 1590828 because we cannot error in async code.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1600121: netwerk: error on empty path in nsIHttpServer.registerPathHandler;

It should be illegal to add paths that cannot be handled/accessed
or later referenced. Without a path, it is for example later
impossible to delete the handler.

To address this we return an NS_ERROR_INVALID_ARG when
nsIHttpServer.registerPathHandler is called with an empty string.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1600121: remote: rely on nsIHttpServer.registerPathHandler to assert path

As nsIHttpServer.registerPathHandler now checks that the path is
not empty we can drop our pre-check when target-created is handled.

If target.path does happen to be empty an error is printed to the console.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40b6d9ae0601
netwerk: error on empty path in nsIHttpServer.registerPathHandler; r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/0342c32685da
remote: rely on nsIHttpServer.registerPathHandler to assert path r=remote-protocol-reviewers,maja_zf,whimboo

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/40b6d9ae0601
https://hg.mozilla.org/mozilla-central/rev/0342c32685da