Closed Bug 1590874 Opened 6 years ago Closed 6 years ago

[jsdbg2] Breakpoint dispatcher includes unnecessary check for Wasm breakpoints

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: jimb, Assigned: loganfsmyth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1590874 - Rely on per-WasmInstance WasmBreakpointSite objects. r=jimb!
47 bytes, text/x-phabricator-request
Details

DebugAPI::onTrap filters out breakpoints set on other wasm::Instances, but breakpoint sites are owned by a specific wasm::Instance now, so that check is unnecessary and confusing.

Blocks: 1590881
Priority: -- → P3
Assignee: nobody → loganfsmyth
Blocks: dbg-72
Status: NEW → ASSIGNED
Pushed by loganfsmyth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/373ebff70ac2 Rely on per-WasmInstance WasmBreakpointSite objects. r=jimb

https://hg.mozilla.org/mozilla-central/rev/373ebff70ac2

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: