1590881 - [jsdbg2] `BreakpointSite::type`, `asJS` and `asWasm` are a poor fit for the abstract base class concept

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jim Blandy :jimb]

The BreakpointSite abstract base class has a Type enum and a type method, which is inconsistent with the idea of an abstract base class, since it forces the base class to enumerate all the concrete classes. The reader cannot assume that logic specific to each concrete class is actually localized in that class's implementation, since any user of a BreakpointSite can downcast it.

It would be easy enough to replace uses of type, isJS and isWasm with virtual methods that serve the same purposes they're put to:

• retrieving the owning cell, for memory use tracking
• retrieving the code's realm, for use in debuggee removal

Then Type, type, asWasm, and asJS could be removed.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1590881 - Remove BreakpointSite .type/asWasm()/asJS() to simplify interface. r=jimb!

Depends on D52277

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aad72f40920e
Remove BreakpointSite .type/asWasm()/asJS() to simplify interface. r=jimb

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/aad72f40920e