1590885 - Expose line-wrap as option in the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[:Harald Kirschner :digitarald]

Bug 1108132 landed devtools.debugger.ui.editor-wrapping. Lets expose it in the Debugger, either context menu now and/or settings menu later.

Comment 1

[:Harald Kirschner :digitarald]

Related: https://discourse.mozilla.org/t/long-line-wrapping-in-developer-tools-css-editor-and-debugger-code-views/47058

Comment 2

[:Harald Kirschner :digitarald]

David, would this be a gfb?

Comment 3

[David Walsh :davidwalsh]

Kevin, I think this would be right up your alley! We recently implemented a gear icon for the console -- I think we could do the same for line wrap, inline preview, etc. for the debugger!

Comment 4

[:Harald Kirschner :digitarald]

v0 for this could just add it to the context menu in the source.

One caveat I noticed, with line wrap on in Debugger, switching Debugger tab with pretty-printed file open took several seconds due to several expensive layouts from code mirror; probably some code path that only gets hit for line-wrapped views.

Comment 5

[Kevin Morehouse]

I can work on this.

Thanks for the recommendation, David!

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigning to you, thanks for the help.
Honza

Comment 7

[Kevin Morehouse]

Attachment: SourcesContextMenu.png

Honza, just to clarify:

When you say "add it to the context menu in the source", are you referring to the context menu in the Sources tree (highlighted in red)?

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Kevin Morehouse from comment #7)

When you say "add it to the context menu in the source", are you referring to the context menu in the Sources tree (highlighted in red)?

It could also be the context menu in the source code preview (or both).
Let's ask Harald what he had in mind.

Honza

Comment 9

[:Harald Kirschner :digitarald]

It could also be the context menu in the source code preview (or both).

Right, context menu in the source of a file, where we also show Inline Preview as option.

Comment 10

[Kevin Morehouse]

Ok, great. Thank you both. Apologies for any confusion my last message may have caused.

Comment 11

[:Harald Kirschner :digitarald]

Just something to QA after this; I had to disable the line-wrap option as it caused severe multi-second hangs when switching from Debugger to Console (something in code mirror).

Comment 12

[Kevin Morehouse]

Can I be please be removed from this? I don't currently have the time to work on it. I'll come back if anything changes. Thanks!

Comment 13

[:Harald Kirschner :digitarald]

(clear ni?)

Comment 14

[luc4leone]

Attachment: wrap long lines in editor context menu

(In reply to :Harald Kirschner :digitarald from comment #9)

It could also be the context menu in the source code preview (or both).

Right, context menu in the source of a file, where we also show Inline Preview as option.

Did I understood it right Harald?

Comment 15

[:Harald Kirschner :digitarald]

Yes, this nails it :)

Comment 16

[luc4leone]

(In reply to :Harald Kirschner :digitarald from comment #15)

Yes, this nails it :)

Thanks Harald :)

I managed to make it work, but I have a doubt. It works only if after toggling the context menu item I close (and then open) the Dev Tools. Is that how it's supposed to work, or lines should wrap immediately after toggling? I made a 34s video to explain this point better: https://www.dropbox.com/s/r9w6ccu9ory5z8f/01_should-it-work-like-that.mov?dl=0

As for the context menu item label for now I wrote Wrap long lines / Unwrap long lines. A shorter option might be Wrap lines / Unwrap lines. I started with a verb because that's what the other labels do. There are many other options. For example Textmate editor uses Wrap column, while VSCode in general starts with Word wrap (there are a few options regarding wrapping). What do you think is the best copy?

Comment 17

[luc4leone]

Hi Jason, I'd like to be assigned to this one. Should I first submit a patch and then wait for feedback or better wait for an answer to my doubt (see my comment above)? Thanks.

Comment 18

[Jason Laster [:jlast]]

I'd submit a patch. that always helps.

Comment 19

[luc4leone]

Attachment: Bug 1590885 - Expose line-wrap as an option in the debugger editor context menu. r=jlast

Added an option to the debugger editor context menu for the user to be able to wrap / unwrap long lines.

Comment 20

[:Harald Kirschner :digitarald]

Let's see if we can get this unstuck …

Comment 21

[luc4leone]

(In reply to :Harald Kirschner :digitarald from comment #20)

Let's see if we can get this unstuck …

Hi Harald,

I submitted a patch https://phabricator.services.mozilla.com/D60681#C2083687NL61 a couple of weeks ago. I need to take care of a Lint error about function complexity, and I need to write the code to change the app state, because right now the app updates only if I close and re-open it, which I guess, it's not the expected behavior. I'll try to do it this week, is that OK with you?

Comment 22

[:Harald Kirschner :digitarald]

Thanks for the ping back luc4leone! It is OK to take your time – mostly wanted to check if I had dropped the ball of if you were waiting on input from us.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dc89b5597d8
Expose line-wrap as an option in the debugger editor context menu. r=nchevobbe

Comment 24

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2dc89b5597d8