Change logic for the Graphs view "Add related configurations" hyperlinks
Categories
(Tree Management :: Perfherder, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: igoldan, Unassigned)
Details
STR
- Go to a plotted graph of a signature which can have multiple combinations of
extra_options
(build times example, a11yr example) - Click on the first hyperlink from top-left (one that starts with build times and a11yr respectively)
Expected results:
We should have a list of about 13 related tests for build times & a single related test for a11yr respectively. All originate from the same repository & the same platform, just like the initial signature from each case.
What we get instead:
No related tests found for both cases.
A bit of context to understand more on what's to be fixed here: these signature properties ensure uniqueness for each perf signature. The hyperlink from our example is taking into account 3 of these fields: suite
, test
& extra_options
.
Basically, when we click on it, we should bring in related signatures which have the same suite
, test
but different extra_options
.
Updated•5 years ago
|
Comment 1•5 years ago
|
||
I've looked into this and it's not a regression per the old angular code: https://github.com/mozilla/treeherder/pull/5053/files#diff-30e3c5e057bc86a56c89530b58b3be63L1081
The current implementation contains the same logic: https://github.com/mozilla/treeherder/blob/master/ui/perfherder/graphs/TestDataModal.jsx#L112
What you're wanting is a change of behavior.
Updated•5 years ago
|
Updated•5 years ago
|
Description
•