1591093 - Add telemetry to the profiler popup

Status: NEW

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P2)

Description

[Greg Tatum [:gregtatum] (REO Fx132)]

We should probably add:

• Profiler button clicked
• After profile capture
• Features changed
• Threads list changed
• Interval changed
• Buffer size changed

We should specifically avoid:

• Profiler start, as this may cause overhead

Comment 1

[:Harald Kirschner :digitarald]

P1s should cover the critical path for recording a profile:

1. Event for toolbar popup opened
2. Event for starting profile, property for which preset was used
3. Event for capturing profile

Should we break them out into their own bugs, blocking this one?

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Splitting it out into multiple bugs might be a bit excessive, as these will be a few lines of code each, but it's probably fine to split out P1s into a separate one.

2. Event for starting profile, property for which preset was used

I believe I called this one out as something to be avoided, as we don't want to create overhead starting the profiler, as this could skew results. We could capture the preset information after profile capture and cancel, which would effectively be the same metric.

Comment 3

[:Harald Kirschner :digitarald]

We could capture the preset information after profile capture and cancel, which would effectively be the same metric.

Makes sense. So we would record:

3. Event for capturing profile, properties for preset and duration