1591249 - Bump coreaudio-sys to 0.2.3

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P3)

Description

[C.M.Chang[:chunmin]]

The cross-compiling issue mentioned in bug 1569003 is solved by https://github.com/RustAudio/coreaudio-sys/pull/28 and that fix is released within coreaudio-sys 0.2.3. We should use coreaudio-sys 0.2.3. directly instead of using a custom 0.2.2 version.

The coreaudio-sys 0.2.3. should be tested with sccache before being bumpped, in case we won't run into similar issue to bug 1590890 .

Comment 1

[C.M.Chang[:chunmin]]

Attachment: GitHub Pull Request

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1591249 - Bump coreaudio-sys to 0.2.3. r=glandium

The current coreaudio-sys in gecko is a custom 0.2.2 version that used
to avoid the cross-compiling issue mentioned in bug 1569003. The issue
has been fixed in the coreaudio-sys 0.2.3, so we should follow the
upstream instead of using a custom version.

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1591249 - P2: Bump coreaudio-sys to 0.2.3. r?glandium

Depends on D50531

Comment 4

[C.M.Chang[:chunmin]]

I don't have a sccache so I need to set it and try if the patches work with it.

Comment 5

[C.M.Chang[:chunmin]]

Comment on attachment 9104070 [details] [review]
GitHub Pull Request

The change in the pull request won't affect the version bump of _coreaudio-sys_

Comment 6

[C.M.Chang[:chunmin]]

(In reply to C.M.Chang[:chunmin] from comment #4)

I don't have a sccache so I need to set it and try if the patches work with it.

The patch can work with my sccache with default setting in https://firefox-source-docs.mozilla.org/build/buildsystem/sccache-dist.html (Rust 1.38 and MacOSX10.11.sdk)

Comment 7

[C.M.Chang[:chunmin]]

Oh it fails on try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=290037d015f4c81a9432b4dc49494d7a9f720cd3&selectedJob=272877291

Comment 8

[Haik Aftandilian [:haik]]

(In reply to C.M.Chang[:chunmin] from comment #4)

I don't have a sccache so I need to set it and try if the patches work with it.

 0:02.34 ERROR: Couldn't execute `cargo metadata` with manifest "/Users/haftandilian/r/mc/toolkit/library/rust/Cargo.toml": Metadata(Output { status: ExitStatus(ExitStatus(25856)), stdout: "", stderr: "error: failed to select a version for `coreaudio-sys`.\n    ... required by package `coreaudio-sys-utils v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs/coreaudio-sys-utils)`\n    ... which is depended on by `cubeb-coreaudio v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs)`\n    ... which is depended on by `gkrust-shared v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/rust/shared)`\n    ... which is depended on by `gkrust-gtest v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/gtest/rust)`\nversions that meet the requirements `= 0.2.3` are: 0.2.3\n\nthe package `coreaudio-sys-utils` depends on `coreaudio-sys`, with features: `nobindgen` but `coreaudio-sys` does not have these features.\n\n\nfailed to select a version for `coreaudio-sys` which could resolve this conflict\n" })
 0:02.34 ERROR: Couldn't generate bindings for /Users/haftandilian/r/mc/toolkit/library/rust.
 0:02.34 make[4]: *** [.deps/ServoStyleConsts.h.stub] Error 1
 0:02.34 make[3]: *** [layout/style/export] Error 2
 0:02.34 make[3]: *** Waiting for unfinished jobs....
 0:02.57 ERROR: Couldn't execute `cargo metadata` with manifest "/Users/haftandilian/r/mc/toolkit/library/rust/Cargo.toml": Metadata(Output { status: ExitStatus(ExitStatus(25856)), stdout: "", stderr: "    Blocking waiting for file lock on package cache\nerror: failed to select a version for `coreaudio-sys`.\n    ... required by package `coreaudio-sys-utils v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs/coreaudio-sys-utils)`\n    ... which is depended on by `cubeb-coreaudio v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs)`\n    ... which is depended on by `gkrust-shared v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/rust/shared)`\n    ... which is depended on by `gkrust-gtest v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/gtest/rust)`\nversions that meet the requirements `= 0.2.3` are: 0.2.3\n\nthe package `coreaudio-sys-utils` depends on `coreaudio-sys`, with features: `nobindgen` but `coreaudio-sys` does not have these features.\n\n\nfailed to select a version for `coreaudio-sys` which could resolve this conflict\n" })
 0:02.57 ERROR: Couldn't generate bindings for /Users/haftandilian/r/mc/toolkit/library/rust.
 0:02.58 make[4]: *** [.deps/webrender_ffi_generated.h.stub] Error 1
 0:02.58 make[3]: *** [gfx/webrender_bindings/export] Error 2
 0:02.83 ERROR: Couldn't execute `cargo metadata` with manifest "/Users/haftandilian/r/mc/toolkit/library/rust/Cargo.toml": Metadata(Output { status: ExitStatus(ExitStatus(25856)), stdout: "", stderr: "    Blocking waiting for file lock on package cache\nerror: failed to select a version for `coreaudio-sys`.\n    ... required by package `coreaudio-sys-utils v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs/coreaudio-sys-utils)`\n    ... which is depended on by `cubeb-coreaudio v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs)`\n    ... which is depended on by `gkrust-shared v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/rust/shared)`\n    ... which is depended on by `gkrust-gtest v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/gtest/rust)`\nversions that meet the requirements `= 0.2.3` are: 0.2.3\n\nthe package `coreaudio-sys-utils` depends on `coreaudio-sys`, with features: `nobindgen` but `coreaudio-sys` does not have these features.\n\n\nfailed to select a version for `coreaudio-sys` which could resolve this conflict\n" })
 0:02.83 ERROR: Couldn't generate bindings for /Users/haftandilian/r/mc/toolkit/library/rust.
 0:02.84 make[4]: *** [.deps/gk_rust_utils_ffi_generated.h.stub] Error 1
 0:02.84 make[3]: *** [xpcom/base/export] Error 2
 0:02.84 make[2]: *** [export] Error 2
 0:02.84 make[1]: *** [default] Error 2
 0:02.84 make: *** [build] Error 2
 0:02.88 355 compiler warnings present.

Comment 9

[C.M.Chang[:chunmin]]

(In reply to Haik Aftandilian [:haik] from comment #8)

 0:02.34 ERROR: Couldn't execute `cargo metadata` with manifest "/Users/haftandilian/r/mc/toolkit/library/rust/Cargo.toml": Metadata(Output { status: ExitStatus(ExitStatus(25856)), stdout: "", stderr: "error: failed to select a version for `coreaudio-sys`.\n    ... required by package `coreaudio-sys-utils v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs/coreaudio-sys-utils)`\n    ... which is depended on by `cubeb-coreaudio v0.1.0 (/Users/haftandilian/r/mc/media/libcubeb/cubeb-coreaudio-rs)`\n    ... which is depended on by `gkrust-shared v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/rust/shared)`\n    ... which is depended on by `gkrust-gtest v0.1.0 (/Users/haftandilian/r/mc/toolkit/library/gtest/rust)`\nversions that meet the requirements `= 0.2.3` are: 0.2.3\n\nthe package `coreaudio-sys-utils` depends on `coreaudio-sys`, with features: `nobindgen` but `coreaudio-sys` does not have these features.\n\n\nfailed to select a version for `coreaudio-sys` which could resolve this conflict\n" })

It looks like it try using nobindgen in coreaudio-sys. Feature nobindgen is removed after bumping up the coreaudio-sys to 0.2.3. The current coreaudio-sys-utils doesn't use nobindgen. Is it built on top of the patch D50529?
(I will submit a patch to remove nobindgen if D50529 is landed first.)

Comment 10

[Chris Manchester (limited bugmail, email directly)]

I tried some version of this (bumping to 0.2.3) locally yesterday and it succeeded with sccache.

Comment 11

[C.M.Chang[:chunmin]]

(In reply to C.M.Chang[:chunmin] from comment #7)

Oh it fails on try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=290037d015f4c81a9432b4dc49494d7a9f720cd3&selectedJob=272877291

I guess I need to set COREAUDIO_SDK_PATH so the build.rs could work in a MacOS environment built on Linux. I tried exporting COREAUDIO_SDK_PATH in build/macosx/cross-mozconfig.common but the build still fails.

Comment 12

[C.M.Chang[:chunmin]]

glandium, do you know where the COREAUDIO_SDK_PATH should be set?

Comment 13

[Mike Hommey [:glandium]]

The problem is not that you need to set COREAUDIO_SDK_PATH, but that the 10.11 SDK doesn't have AudioUnit. You need to disable the audio_unit feature.

Comment 14

[Mike Hommey [:glandium]]

I guess one thing that could be done in coreaudio-sys upstream is to add some has_include checks to avoid having to manually disable features that aren't provided by the SDK.

Comment 15

[C.M.Chang[:chunmin]]

(In reply to C.M.Chang[:chunmin] from comment #11)

I guess I need to set COREAUDIO_SDK_PATH so the build.rs could work in a MacOS environment built on Linux. I tried exporting COREAUDIO_SDK_PATH in build/macosx/cross-mozconfig.common but the build still fails.

Set COREAUDIO_SDK_PATH to MACOS_SDK_DIR in rust.mk works both in my local build and try server, with Mac 10.11 SDK. I will upload those patches once they pass the tests.

Comment 16

[C.M.Chang[:chunmin]]

Attachment: Bug 1591249 - P3: Remove nobindgen. r?glandium

The feature nobingen is a custom feature in our custom coreaudio-sys
0.2.2 that is removed in the previous patch. It no longer exists after
bumping up the coreaudio-sys to 0.2.3.

Comment 17

[C.M.Chang[:chunmin]]

Attachment: Bug 1591249 - P4: Set COREAUDIO_SDK_PATH to MACOS_SDK_DIR. r?glandium

The coreaudio-sys should generate API bindings based on MACOS_SDK_DIR if
it's set.

Depends on D51126

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65689d355c82
Bump coreaudio-sys to 0.2.3. r=glandium

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/65689d355c82

Comment 20

[C.M.Chang[:chunmin]]

Attachment: Bug 1591249 - Update cubeb-coreaudio-rs to cd954ca. r?padenot

Pick commits:
cd954ca - Update dependencies (#22)
7043a0c - Make audiounit_get_devices_of_type infallible (#21)

Comment 21

[Phabricator Automation]

Comment on attachment 9106351 [details]
Bug 1591249 - Update cubeb-coreaudio-rs to cd954ca. r?padenot

Revision D51725 was moved to bug 1590151. Setting attachment 9106351 [details] to obsolete.