1591262 - clang cross-compiling to windows changed linkage behavior with clang 9 breaking sccache-dist

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

MIDL generated code in our build re-defines extern to static a lot and depends on the result being static to avoid duplicate symbol errors when linking. The behavior of our clang when targeting windows from a linux host changed with the clang 9 update, breaking sccache-dist builds.

dmajor, does this sound familiar at all? Is there a set of options we can pass to force the old behavior?

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Ok, I found https://bugs.llvm.org/show_bug.cgi?id=41817, I probably just need to apply the reverting patch when building the cross-toolchain.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1591262 - Apply additional patch to clang used for sccache-dist builds.

This applies one of the patches we needed to build on windows to the clang
we're using for sccache-dist builds. The upstream issue is described in
https://bugs.llvm.org/show_bug.cgi?id=41817

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca923afe3ed4
Apply additional patch to clang used for sccache-dist builds. r=firefox-build-system-reviewers,dmajor

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ca923afe3ed4