1592402 - Two clang compilers have toolchain-alias "linux64-clang"

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect, P1)

Description

[Rob Lemley [:rjl]]

Two of the clang compilers have the same toolchain alias, linux64-clang.
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/taskcluster/ci/toolchain/clang.yml#60,80

It doesn't seem to be causing a problem, but Thunderbird references the alias "linux64-clang" when building for Linux, so it's actually building with "linux64-clang-9-cross" the past few days.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Chris, seems that it is your change in bug 1591262

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1592402 - Remove erroneous duplicate toolchain alias.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Chris, do you think we should write a lint to avoid this from happening again?

Comment 4

[Chris Manchester (limited bugmail, email directly)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #3)

Chris, do you think we should write a lint to avoid this from happening again?

Yes, I'm pretty surprised this is possible, I would have expected a hard error. I filed bug 1592419.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aac5a4c03aeb
Remove erroneous duplicate toolchain alias. r=froydnj

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/aac5a4c03aeb

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aac5a4c03aeb