Closed
Bug 1591361
Opened 5 years ago
Closed 5 years ago
remove some getAnonymousNodes calls (dead code)
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 72.0
People
(Reporter: mkmelin, Assigned: mkmelin)
Details
Attachments
(1 file, 1 obsolete file)
|
25.42 KB,
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
From bug 1591145 comment 5.
|
Assignee | |
Comment 1•5 years ago
|
||
Should be dead code, let's see if try can confirm
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0f6822eb2dea99f9a3889c41d41a4c97aa444027
Attachment #9104174 -
Flags: review?(jorgk)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Comment on attachment 9104174 [details] [diff] [review]
bug1591361_getAnonymousNode.patch
Review of attachment 9104174 [details] [diff] [review]:
-----------------------------------------------------------------
More fixing needed
Attachment #9104174 -
Flags: review?(jorgk)
|
|
Assignee | |
Comment 3•5 years ago
|
||
Successful try, I've fixed the lint: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0d2c9384ce5b542e3652b687b3c88db71e1fb04e&selectedJob=272950987
Attachment #9104174 -
Attachment is obsolete: true
Attachment #9104310 -
Flags: review?(jorgk)
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9104310 [details] [diff] [review]
bug1591361_getAnonymousNode.patch
This really needs a Calendar reviewer. I put two here. First reviewer wins ;-)
r+ on the non-Calendar part.
Attachment #9104310 -
Flags: review?(paul)
Attachment #9104310 -
Flags: review?(jorgk)
Attachment #9104310 -
Flags: review?(geoff)
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9104310 [details] [diff] [review]
bug1591361_getAnonymousNode.patch
Review of attachment 9104310 [details] [diff] [review]:
-----------------------------------------------------------------
r+ on the calendar parts.
Attachment #9104310 -
Flags: review?(paul)
Attachment #9104310 -
Flags: review?(geoff)
Attachment #9104310 -
Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d7074a5597c7
remove remaining getAnonymousNodes calls (soon to be removed from platform). r=pmorris,jorgk
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 72.0
You need to log in
before you can comment on or make changes to this bug.
Description
•