1591399 - Nick highlight and emoticons broken in chat

Status: VERIFIED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Patrick Cloke [:clokep]]

I updated to Thunderbird 71 beta 1 today and I noticed a couple of things broken in chat, I'm unsure if they're related but they smell like they probably are:

• (Using the bubbles theme) if someone pings you (or if you mention someone) their name is not highlighted properly.
• Emoticons are not rendered from text into images.

Comment 1

[Patrick Cloke [:clokep]]

I do not seem to see any errors in the console that might be related to this.

Comment 2

[Patrick Cloke [:clokep]]

This can be seen easily be going into the chat preferences and looking at the theme.

Comment 3

[Patrick Cloke [:clokep]]

Alice, would you be able to track down when this broke? It works fine in 70b4, broken in 71b1.

The easiest way to test this is to:

1. Go to the preferences
2. Click on the "Chat" tab
3. Look under "Styling"
4. The first line says "Hi! :-)", it should show a smile image instead of the text :-)

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=79bcd5d1148477ce4b3c611ebd83205eea186598&tochange=a128f9557e9db7951a9d8d6467e553fdccb8a0f5
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=79bcd5d1148477ce4b3c611ebd83205eea186598&tochange=a128f9557e9db7951a9d8d6467e553fdccb8a0f5

Comment 5

[Patrick Cloke [:clokep]]

Thank you Alice! :)

Comment 6

[Patrick Cloke [:clokep]]

This is regressed by bug 1570954.

I'm unsure of the difference from firstChild/firstElementChild and friends, any idea what might be causing this?

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1591399_im_smiley.patch

Seems to fix it for me.

Comment 8

[Jorg K (CEST = GMT+2)]

Just a reversal of https://hg.mozilla.org/comm-central/rev/a128f9557e9db7951a9d8d6467e553fdccb8a0f5#l40.1

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 9104330 [details] [diff] [review]
bug1591399_im_smiley.patch

Having some issues building right now, so I wasn't able to test this, but I think this will fix it.

Comment 10

[Jorg K (CEST = GMT+2)]

I tested it. Changing the summary to what was actually broken.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/450ec65c9b9f
fix nick highlight and emoticons in chat. r=clokep

Comment 12

[Jorg K (CEST = GMT+2)]

Sadly the reason for the failure/fix weren't stated here. Bug 1570954 changed
firstChild->firstElementChild
lastChild->lastElementChild
nextSibling->nextElementSibling
previousSibling->previousElementSibling
childNodes->children
to prepare for the XUL to XHTML transition, so basically JS operating on XUL files will need to change when the XUL files become XHTML files.

JS operating on HTML was explicitly excluded "whole-sale" in bug 1570954, see the reversals in the checkin comment in https://hg.mozilla.org/comm-central/rev/a128f9557e9d.

The chat document in question was already HTML, so the corresponding JS code shouldn't have been changed and a reversal fixed the issue.

Comment 13

[Patrick Cloke [:clokep]]

(In reply to Jorg K (GMT+2) from comment #12)

The chat document in question was already HTML, so the corresponding JS code shouldn't have been changed and a reversal fixed the issue.

Thanks for posting the explanation in here, and this is the important piece here -- these functions deal with the HTML of the chat pane itself, not the UI surrounding the chat pane.

Thanks for the beta approval!

Comment 14

[Jorg K (CEST = GMT+2)]

TB 71 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/5a596857b17a50819c55844b2e62967998d9b446

Comment 15

[Patrick Cloke [:clokep]]

I verified that this works fine on a custom built Thunderbird from today's tip.