1591433 - SuperflousAuth Anti-phishing prompt does not show

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Paul Zühlcke [:pbz]]

Attachment: confirmauth.png

The SuperfluousAuth prompts added in Bug 232567 do not show anymore.

Via mozregression I found this range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f748a3d2cdf108e9443fd15332efe477c7c398a9&tochange=25b533bff4051e6a8177bbc83eed49ac460e109e

Setting browser.tabs.documentchannel to false fixes this. So I assume Bug 1583700 introduced this behavior.

For example opening https://[e-mail] should trigger prompt (see screenshot attached).

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1591433 - Support getting an nsIPrompt from DocumentChannelParent, in the same way as HttpChannelParent does. r?mayhemer

Depends on D50894

Comment 2

[Honza Bambas (:mayhemer)]

Michal, please check comment in phab on the patch, thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b10a397e32f
Support getting an nsIPrompt from DocumentChannelParent, in the same way as HttpChannelParent does. r=mayhemer

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2b10a397e32f

Comment 5

[Hani Yacoub, Desktop QA]

On both old and new builds I get redirected to "https://eviltrap.site/" when accessing the link "https://[e-mail]", the prompt screenshot from the description isn't displayed.
Is it possible that this bug is not fixed?

Comment 6

[Paul Zühlcke [:pbz]]

We currently have these prompts disabled by default due to a DoS issue. See Bug 1571003.
Once we support tab modal prompting, something I'm currently working on, I think we can enable them again.