1591469 - [Fission] Port AboutReaderChild.jsm to JSWindowActors

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Here's AboutReaderChild.jsm: https://searchfox.org/mozilla-central/rev/2a355e56c490768be676689de18629485c9d699b/browser/actors/AboutReaderChild.jsm

And here's where it is registered with the old message manager actors system: https://searchfox.org/mozilla-central/rev/2a355e56c490768be676689de18629485c9d699b/browser/components/BrowserGlue.jsm#215-227

there's already a ReaderParent.jsm here: https://searchfox.org/mozilla-central/rev/2a355e56c490768be676689de18629485c9d699b/browser/modules/ReaderParent.jsm which will likely need to get ported to JSWindowActorParent, or have a JSWindowActorParent call into it.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Also note this other sender of a ReaderMode message: https://searchfox.org/mozilla-central/rev/2a355e56c490768be676689de18629485c9d699b/browser/base/content/browser.js#6328-6330

Comment 2

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 3

[Chris Peterson [:cpeterson]]

M6 because Reader View doesn't block dogfooding (M5).

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hi Teja,

Were you still planning on hacking on this, or can we commandeer the bug from you? If we don't hear back in a few weeks, we'll assume we can unassign the bug.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Haven't heard back from Teja, so unassigning for now.

Comment 6

[Chris Peterson [:cpeterson]]

Tentatively moving P1 Fission M6 bugs to M6a.

Comment 7

[Neil Deakin]

Attachment: Bug 1591469, move reader mode to use JSWindowActor instead of message managers, r=gijs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a50d857d097
move reader mode to use JSWindowActor instead of message managers, r=Gijs

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 3a50d857d097 (bug 1591469) for newtab failures complaining about AboutReaderParent

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-newtab-unit-tests%2Cnode%28newtab%29&fromchange=de6d1c1375eebf27d9e52aafba5b4138581e35c0&tochange=03a111855a06c370fd8ef2d473486c983881321e&selectedTaskRun=AoJ2ypoyT9GsXyCS6PQW0Q-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/03a111855a06c370fd8ef2d473486c983881321e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301838710&repo=autoland&lineNumber=333

[task 2020-05-12T02:52:42.973Z] TEST START | karma
[task 2020-05-12T02:54:07.096Z] npm ERR! code ELIFECYCLE
[task 2020-05-12T02:54:07.096Z] npm ERR! errno 1
[task 2020-05-12T02:54:07.096Z] npm ERR! activity-streams@1.14.3 testmc:unit: `karma start karma.mc.config.js`
[task 2020-05-12T02:54:07.096Z] npm ERR! Exit status 1
[task 2020-05-12T02:54:07.096Z] npm ERR! 
[task 2020-05-12T02:54:07.096Z] npm ERR! Failed at the activity-streams@1.14.3 testmc:unit script.
[task 2020-05-12T02:54:07.096Z] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[task 2020-05-12T02:54:07.096Z] 
[task 2020-05-12T02:54:07.096Z] npm ERR! A complete log of this run can be found in:
[task 2020-05-12T02:54:07.096Z] npm ERR!     /builds/worker/.npm/_logs/2020-05-12T02_54_07_082Z-debug.log
[task 2020-05-12T02:54:07.119Z] TEST-UNEXPECTED-FAIL karma | activity-stream:ASRouterTriggerListeners:openArticleURL:#init setup an event listener on init: AboutReaderParent is not defined
[task 2020-05-12T02:54:07.119Z] init@http://localhost:9876/base/test/unit/unit-entry.js?918eb438cadb770b1fa517e36feeeed833c7055a:114880:7
[task 2020-05-12T02:54:07.119Z] @http://localhost:9876/base/test/unit/unit-entry.js?918eb438cadb770b1fa517e36feeeed833c7055a:116549:32
[task 2020-05-12T02:54:07.119Z] 
[task 2020-05-12T02:54:07.119Z] TEST-UNEXPECTED-FAIL karma | activity-stream:ASRouterTriggerListeners:openArticleURL:#init should call triggerHandler correctly for matches [host match]: AboutReaderParent is not defined
[task 2020-05-12T02:54:07.119Z] init@http://localhost:9876/base/test/unit/unit-entry.js?918eb438cadb770b1fa517e36feeeed833c7055a:114880:7
[task 2020-05-12T02:54:07.119Z] @http://localhost:9876/base/test/unit/unit-entry.js?918eb438cadb770b1fa517e36feeeed833c7055a:116561:32
[task 2020-05-12T02:54:07.119Z] 
[task 2020-05-12T02:54:07.119Z] TEST-UNEXPECTED-FAIL karma | activity-stream:ASRouterTriggerListeners:openArticleURL:#init should call triggerHandler correctly for matches [pattern match]: AboutReaderParent is not defined
[task 2020-05-12T02:54:07.119Z] init@http://localhost:9876/base/test/unit/unit-entry.js?918eb438cadb770b1fa517e36feeeed833c7055a:114880:7
[task 2020-05-12T02:54:07.119Z] @http://localhost:9876/base/test/unit/unit-entry.js?918eb438cadb770b1fa517e36feeeed833c7055a:116578:32
[task 2020-05-12T02:54:07.119Z] 
[task 2020-05-12T02:54:07.119Z] TEST-UNEXPECTED-FAIL karma | activity-stream:ASRouterTriggerListeners:openArticleURL:#init should remove the message listener: AboutReaderParent is not defined
[task 2020-05-12T02:54:07.119Z] init@http://localhost:9876/base/test/unit/unit-entry.js?918eb438cadb770b1fa517e36feeeed833c7055a:114880:7

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/217394da44ac
move reader mode to use JSWindowActor instead of message managers, r=Gijs

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/217394da44ac