Closed
Bug 1591522
Opened 6 years ago
Closed 2 years ago
Add "flatten" argument to Target.attachToTarget
Categories
(Remote Protocol :: CDP, enhancement, P3)
Remote Protocol
CDP
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: whimboo, Unassigned)
References
()
Details
(Whiteboard: [puppeteer-beta2-mvp])
The flatten argument hasn't been implemented yet. For Puppeteer support with Gutenberg we have to add it for the alpha release.
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P2
|
||
Comment 1•6 years ago
|
||
This is used in Puppeteer, here:
https://github.com/GoogleChrome/puppeteer/blob/62da2366c65b335751896afbb0206f23c61436f1/lib/Connection.js#L153
|
||
Updated•6 years ago
|
Priority: P2 → P3
Whiteboard: [puppeteer-alpha] → [puppeteer-alpha-reserve]
|
|
||
Updated•6 years ago
|
Priority: P3 → P2
Whiteboard: [puppeteer-alpha-reserve] → [puppeteer-beta-mvp]
|
|
Reporter | |
Updated•5 years ago
|
Priority: P2 → P3
Whiteboard: [puppeteer-beta-mvp] → [puppeteer-beta-reserve]
Type: task → enhancement
Perhaps we're already using flattened by default?
|
|
Reporter | |
Comment 3•5 years ago
|
||
As I understood when talking to Joe Einbinder on Riot was that whenver the sessionId isn't send for each request, the flattened mode is in use. So we should do it by default, yes.
Whiteboard: [puppeteer-beta-reserve] → [puppeteer-beta2-mvp]
|
Assignee | |
Updated•4 years ago
|
Component: CDP: Target → CDP
|
||
Updated•3 years ago
|
Severity: normal → S3
|
|
Reporter | |
Comment 4•2 years ago
|
||
So far this was not a blocker. That means I do not see a requirement to get this still added to our CDP implementation.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•