1591531 - Text of messages not legible due to font contrast in summary view in message pane (dark theme) with dark OS system theme or ui.systemUsesDarkTheme set to 1 (to simulate)

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[vtol]

Attachment: screen shot message pane

• TB 71.0b1 (64-bit) on W10 Pro x_64 v1809 b19362.418

---

appears to be a regression from 70 to 71 since it started to exhibit the issue after the update.

Comment 1

[Jorg K (CEST = GMT+2)]

What's a "mail pane"? Make the screenshot more fuzzy and we can see it even better :-( - Surely you will have some messages which aren't super-private.

Comment 2

[vtol]

Attachment: screen shot message thread body

The part that matters is not blurred since it is illegible anyway.

"mail pane" might have been misleading as being the threaded body rendered by TB . It was meant to point out the area where the issue occurs - in the replaced attachment now being marked with a frame.

Comment 3

[Jorg K (CEST = GMT+2)]

Looks like the nomenclature is a bit difficult here. If in doubt, I refer to http://kb.mozillazine.org/Window_layout_-_Thunderbird.

So basically we're talking about the message pane, also called message preview pane. If you select two or more messages in the thread pane, also called message list, you get a summary view (https://www.tummy.com/blogs/2009/08/20/neat-new-feature-in-thunderbird-3-message-summaries/).

So I think what you're trying to say is that the summarised bodies are not visible. I tried that in TB 71 beta 1 and it looks fine, screenshot to follow.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: summary-view.png

Here's a screenshot from my SPAM folder. I'm not sure why it says "Conversations" and not "Messages", it says "Messages" in TB 68.

I noticed that the scrollbar is no longer styled properly. Richard?

Comment 5

[Jorg K (CEST = GMT+2)]

Another confusion: Looking at bug 1572968 comment #12: Should the options pages be dark? I don't see them dark in TB 71 even with browser.in-content.dark-mode set (which seems to be true by default).

Comment 6

[vtol]

(In reply to Jorg K (GMT+2) from comment #3)

So I think what you're trying to say is that the summarised bodies are not visible. I tried that in TB 71 beta 1 and it looks fine, screenshot to follow.

(In reply to Jorg K (GMT+2) from comment #4)

Here's a screenshot from my SPAM folder. I'm not sure why it says "Conversations" and not "Messages", it says "Messages" in TB 68.

The attchment is indicating that this is not a threaded view (which would be indicated by > in the Subject heading of the list view) but rather having selected multiple unrelated messages. That is also why it shows X conversations instead of X messages.

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: summary-view2.png

I see no difference when I start with a threaded view.

Comment 8

[Richard Marti (:Paenglab)]

Vtol, do you use a dark system theme? How does it look with all Add-ons disabled through the Help menu? For me it seems, you have set a background colour override that makes the background light.

Comment 9

[Richard Marti (:Paenglab)]

With set ui.systemUsesDarkTheme to 1 the background ist dark with white text.

Comment 10

[vtol]

Attachment: dark conf settings

On the same OS?(In reply to Jorg K (GMT+2) from comment #5)

Another confusion: Looking at bug 1572968 comment #12: Should the options pages be dark? I don't see them dark in TB 71 even with browser.in-content.dark-mode set (which seems to be true by default).

(In reply to Richard Marti (:Paenglab) from comment #8)

Vtol, do you use a dark system theme? How does it look with all Add-ons disabled through the Help menu? For me it seems, you have set a background colour override that makes the background light.

(In reply to Richard Marti (:Paenglab) from comment #9)

With set ui.systemUsesDarkTheme to 1 the background ist dark with white text.

The OS theme is dark and TB's dark related conf in the screen shot. ui.systemUsesDarkTheme is not explictily set and was not for the 70 branch.

Comment 11

[vtol]

Attachment: mutiple message selected and text selected in preview pane

(In reply to Jorg K (GMT+2) from comment #7)

Created attachment 9104402 [details]
I see no difference when I start with a threaded view.

That on the same OS? Seems the issue is not only happening with threaded messages grouped but also selecting mutilple messages.

Comment 12

[Jorg K (CEST = GMT+2)]

OS, as in Windows? I'm on Win 10 x64 Pro (1903). Does that matter?

Comment 13

[vtol]

Same as I reported. Sometimes bugs are OS specific, exhibiting differently on different OS.

Comment 14

[Richard Marti (:Paenglab)]

Threaded and multiple messages use both the same multimessage view. Vtol, can you try a new profile?

Comment 15

[Jorg K (CEST = GMT+2)]

I can reproduce the issue. When I set ui.systemUsesDarkTheme, the options pages go dark, and the summary view for multiple selected messages has white-on-white ... and the scrollbar is still too bright :-( - A single message is still shown black text on white background.

Comment 16

[Jorg K (CEST = GMT+2)]

Same as I reported.

Really? TB 71.0b1 (64-bit) on W10 Pro x_64 v1809 b19362.418 - looks like 1809 to me.

Comment 17

[Richard Marti (:Paenglab)]

Sorry, TB beta wasn't updated to 71. With this I see it too. It's also weird, that the background is grey and not white with the light system theme. I'll dig...

Comment 18

[vtol]

Bugger me (missed my caffeine intake), pardon the slip - it is indeed v1903 and b18362.418

---

(In reply to Richard Marti (:Paenglab) from comment #14)

can you try a new profile?

Suppose that with

(In reply to Jorg K (GMT+2) from comment #15)

I can reproduce the issue.

it is not necessary to jump through the hoop of setting up with a vanilla profile because I would raher not. Just reported it but it does not bother me that much in the workflow.

Comment 19

[Richard Marti (:Paenglab)]

Attachment: 1591531-multimessage-colors.patch

Something must have changed that color/and background-color don't apply on <body>. Moving them to :root makes it work again.

Comment 20

[Jorg K (CEST = GMT+2)]

Comment on attachment 9104408 [details] [diff] [review]
1591531-multimessage-colors.patch

Works for me, thanks. I'll fix the commit message to be:
For summary views, set the color/background-color on :root instead body to apply correctly.

It's always good to somehow relate the patch to the issue that's being fixed, in this case, the summary view.

Comment 21

[Richard Marti (:Paenglab)]

No checkin-needed available. Using checkin-needed-tb instead.

Comment 22

[Jorg K (CEST = GMT+2)]

Off-topic: Right, checkin-needed-tb is the new flag in the M-C Phab/Lando world. I just wonder whether raising the bar to use 2FA, Phab, etc. isn't driving away casual contributors. But that's not our problem. We continue with a mix of Splinter, Phab and checkin-needed-tb :-)

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0af98d8c569d
For summary views, set the color/background-color on :root instead body to apply correctly. r=jorgk

Comment 24

[Jorg K (CEST = GMT+2)]

TB 71 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/4bfe6452c61b57defebb73c8ae84c666e7b04cd8