1591608 - Replace the naming for media control keys event related classes with more generic name

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

Now there are some classes using the naming of MediaHardwareKeysXXX. However, the media control key events can come from either physical devices, such as a keyboard or a headset, or from virtual interface, such as SMTC-based visual controller on Windows or MPRIS-based visual controller on Linux.

Therefore, we would be better to rename all those MediaHardwareKeysXXX to MediaControlKeysXXX in order to represent a generic concept.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1591608 - part1 : rename `MediaHardwareKeysXXX` to `MediaControlKeysXXX`.

The media control key events can come from either physical devices, such as a keyboard or a headset, or from virtual interface, such as SMTC-based visual controller on Windows or MPRIS-based visual controller on Linux.

Therefore, we would be better to rename all those MediaHardwareKeysXXX to MediaControlKeysXXX in order to represent a generic concept.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1591608 - part2 : rename files from 'MediaHardwareKeysXXX' to 'MediaControlKeysXXX'.

File's name should reflect what the class is inside the file.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1591608 - part3 : follow the new naming rule for define guards.

Per [1], we should follow our coding style.

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/653caae61e4f
part1 : rename `MediaHardwareKeysXXX` to `MediaControlKeysXXX`. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/22402bfc5b48
part2 : rename files from 'MediaHardwareKeysXXX' to 'MediaControlKeysXXX'. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/9be89065895f
part3 : follow the new naming rule for define guards. r=chunmin

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/653caae61e4f
https://hg.mozilla.org/mozilla-central/rev/22402bfc5b48
https://hg.mozilla.org/mozilla-central/rev/9be89065895f

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/653caae61e4f
https://hg.mozilla.org/integration/mozilla-inbound/rev/22402bfc5b48
https://hg.mozilla.org/integration/mozilla-inbound/rev/9be89065895f