1591791 - Port |Bug 1584809 - PageInfo cookie permissions default to allow| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Ian Neal]

At the moment for pageInfo cookie permissions, if Services.perms.testPermissionFromPrincipal(gPermPrincipal, "cookie") returns SitePermissions.UNKNOWN then the radio group is set to have nothing selected.
When the checkbox is unchecked, the radio group is tested and if it has nothing selected then the assumption is that the permission should be #1 i.e. ALLOW_ACTION
It should be the default for the relevant permission

Comment 1

[Ian Neal]

Attachment: Use getDefault

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Unexpected behaviour if default is set to something other than allow
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9104502 [details] [diff] [review]
Use getDefault

LGTM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f1b5416c152b
Port |Bug 1584809 - PageInfo cookie permissions default to allow| to SeaMonkey. r=frg DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/a6b7aab7e3f5adcd66189fb3ac37e3740b5abbe5

Comment 5

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a4cded863f54e1fa56d0c5184a8bdf38b7eb1197