1592047 - Add visibility info to Autofill elements

Status: NEW

(GeckoView :: General, enhancement, P3)

Description

[James Hugman [:jhugman] [@jhugman]]

Attachment: Screenshot_20191028-175057.png

Currently, the auth0.com has an AssistStructure for the auth.mozilla.auth0.com represented by Fenix, in a XML representation generated by Lockwise:

<form webDomain="auth.mozilla.auth0.com" visibility="0" data-decorator="init-auth handle-submit" action="/" method="post" lock-state="loading" id="nlx-form">
    <fieldset webDomain="auth.mozilla.auth0.com" visibility="0" data-decorator="decide-screen" class=""/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="emailAddress" inputType="21" visibility="0" data-decorator="watch-contents" autocomplete="email" id="field-email" name="username" type="email" autofocus=""/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" id="enter-initial" type="submit" class="button button--full-width"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-firefoxaccounts" type="button" class="button button--full-width button--social button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-github" type="button" class="button button--github button--full-width button--social button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-google" type="button" class="button button--full-width button--social button--secondary"/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" data-decorator="set-autologin-preference" id="use-autologin" type="checkbox" checked=""/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="emailAddress" inputType="21" visibility="0" data-decorator="watch-contents" autocomplete="email" id="field-email-signup" name="username" type="email"/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" id="enter-initial-signup" type="submit" class="button button--full-width"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-firefoxaccounts" type="button" class="button button--full-width button--social button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-github" type="button" class="button button--github button--full-width button--social button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-google" type="button" class="button button--full-width button--social button--secondary"/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" data-decorator="set-autologin-preference" id="use-autologin-2" type="checkbox" checked=""/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="password" inputType="e1" visibility="0" data-decorator="submit-with-enter watch-contents" autocomplete="current-password" data-continue-with="authorise-ldap-credentials" id="field-password" name="password" type="password"/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" id="authorise-ldap-credentials" type="submit" class="button button--full-width"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="go-to-initial-page" type="button" class="button button--text-only card__back button--unpadded"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="send-passwordless-link" type="button" class="button button--full-width button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-firefoxaccounts" type="button" class="button button--full-width button--social button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-github" type="button" class="button button--github button--full-width button--social button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="authorise-google" type="button" class="button button--full-width button--social button--secondary"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="go-to-initial-page" type="button" class="button button--text-only card__back button--unpadded"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="go-to-initial-page" id="back" type="button" class="button button--text-only card__back  button--unpadded"/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="password" inputType="e1" visibility="0" data-decorator="submit-with-enter watch-contents" autocomplete="current-password" data-continue-with="authorise-ldap-credentials" id="field-password-try-2" name="password" type="password"/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" id="authorise-ldap-credentials-try-2" type="submit" class="button button--full-width"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="go-to-initial-page" type="button" class="button button--text-only card__back button--unpadded"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="go-to-initial-page" type="button" class="button button--text-only card__back  button--unpadded"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="go-to-initial-page" type="button" class="button button--text-only card__back button--unpadded"/>
    <button webDomain="auth.mozilla.auth0.com" visibility="0" data-handler="go-to-initial-page" type="button" class="button button--text-only card__back button--unpadded"/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" data-decorator="set-autologin-preference" id="use-autologin-2" type="checkbox" checked=""/>
    <input webDomain="auth.mozilla.auth0.com" visibility="0" data-decorator="set-autologin-preference" id="use-autologin-3" type="checkbox" checked=""/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="password" inputType="e1" visibility="0" autocomplete="current-password" id="hidden-lastpass-password" name="hidden-lastpass-password" type="password" aria-hidden=""/>
</form>

Attached is the corresponding screenshot.

The visibility attribute is derived from ViewNode.getVisibility() which returns View.VISIBLE (0), View.INVISIBLE (4) or View.GONE (8).

Note only the first input field is actually visible.

<input webDomain="auth.mozilla.auth0.com" autofillHints="emailAddress" inputType="21" visibility="0" data-decorator="watch-contents" autocomplete="email" id="field-email" name="username" type="email" autofocus=""/>

This bug is a request either to annotate the fields with visibility or to filter out the fields that are not visible. NB. This is not filtering of type=hidden fields.

Comment 1

[Chris Peterson [:cpeterson]]

Adding to GV's November sprint.

Feature requests from Lockwise to help autofill identify password fields on a page. Eugen thinks we can support these with the new autofill refactoring bug 1591462.

Comment 2

[Eugen Sawin [:esawin]]

Can you please verify whether the changes landed in bug 1591462 satisfy your requirements.

We set ViewStructure.setVisibility based on Autofill.Node.getVisible. An Autofill.Node is considered visible, when it is contained in a "focused branch" as determined by the following conditions:

1. the node is focused, or
2. the node is a sibling of a focused node, or
3. the node is a parent of a focused node, or
4. the node is the Autofill.Session root node

Comment 3

[James Hugman [:jhugman] [@jhugman]]

This does not satisfy requirements.

In the above tree, there are three password fields, and two username fields, simplified below.

In this example, looking at the screenshot, only the first emailAddress field is visible.

<form webDomain="auth.mozilla.auth0.com" visibility="0" data-decorator="init-auth handle-submit" action="/" method="post" lock-state="loading" id="nlx-form">
    <input webDomain="auth.mozilla.auth0.com" autofillHints="emailAddress" inputType="21" visibility="0" data-decorator="watch-contents" autocomplete="email" id="field-email" name="username" type="email" autofocus=""/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="emailAddress" inputType="21" visibility="0" data-decorator="watch-contents" autocomplete="email" id="field-email-signup" name="username" type="email"/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="password" inputType="e1" visibility="0" data-decorator="submit-with-enter watch-contents" autocomplete="current-password" data-continue-with="authorise-ldap-credentials" id="field-password" name="password" type="password"/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="password" inputType="e1" visibility="0" data-decorator="submit-with-enter watch-contents" autocomplete="current-password" data-continue-with="authorise-ldap-credentials" id="field-password-try-2" name="password" type="password"/>
    <input webDomain="auth.mozilla.auth0.com" autofillHints="password" inputType="e1" visibility="0" autocomplete="current-password" id="hidden-lastpass-password" name="hidden-lastpass-password" type="password" aria-hidden=""/>
</form>

Comment 4

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.