1591462 - Refactor autofill mechanics into an Autofill API

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Eugen Sawin [:esawin]]

We should continue the work started in bug 1577003, which introduced AutofillDelegate, AutofillElement and AutofillSupport, by combining the different autofill elements into a more coherent Autofill API.

We should also look into simplifying and documenting some of the original implementations.

In this bug, we can start by moving autofill mechanics out of other modules into the Autofill module and by rewriting the Java parts into a more GV-idiomatic API.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: Bug 1591462 - [1.1] Move autofill mechanics into a dedicated child module.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: Bug 1591462 - [2.1] Combine autofill mechanics in Java API.

Depends on D50630

Comment 3

[Eugen Sawin [:esawin]]

Attachment: Bug 1591462 - [3.0] Adjust autofill tests to the new API and fix naming.

Depends on D50631

Comment 4

[Chris Peterson [:cpeterson]]

Selecting for November sprint.

Comment 5

[Eugen Sawin [:esawin]]

Attachment: Bug 1591462 - [4.2] Disable LoginManager storage for GeckoView.

Depends on D50632

Comment 6

[Eugen Sawin [:esawin]]

Attachment: Bug 1591462 - [5.0] Update changelog.

Depends on D51723

Comment 7

[Eugen Sawin [:esawin]]

Attachment: Bug 1591462 - [6.0] Fix changelog.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a31fae37440
[1.1] Move autofill mechanics into a dedicated child module. r=snorp
https://hg.mozilla.org/integration/autoland/rev/4617ad7f36d4
[2.1] Combine autofill mechanics in Java API. r=snorp,geckoview-reviewers,droeh
https://hg.mozilla.org/integration/autoland/rev/c6c5c9370ab0
[3.0] Adjust autofill tests to the new API and fix naming. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/300057f0ec79
[4.2] Disable LoginManager storage for GeckoView. r=MattN
https://hg.mozilla.org/integration/autoland/rev/d3163cbe3b00
[5.0] Update changelog.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b22289ed3792
[6.0] Fix changelog.

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2a31fae37440
https://hg.mozilla.org/mozilla-central/rev/4617ad7f36d4
https://hg.mozilla.org/mozilla-central/rev/c6c5c9370ab0
https://hg.mozilla.org/mozilla-central/rev/300057f0ec79
https://hg.mozilla.org/mozilla-central/rev/d3163cbe3b00
https://hg.mozilla.org/mozilla-central/rev/b22289ed3792