1592134 - Turn on the display default private search engine feature for Nightly users only - correct patch

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]:

Bug 1590775 was rebased before landing, and ended up turning off permissions.desktop-notification.postPrompt.enabled rather than browser.search.separatePrivateDefault.ui.enabled.

(Though looking at the history, it looks like it was always disabling the wrong pref, but I'm sure I checked it fully before approving it).

This'll need to be uplifted to Fx 71, since it's enabled on EARLY_BETA at the moment.

cc'ing Johann as this might be affecting their telemetry for the last week.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1592134 - Turn on the display of default private search engine feature for Nightly users only. r?mikedeboer

Comment 2

[Johann Hofmann [:johannh]]

Thanks for the heads up!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7290b4ea908c
Turn on the display of default private search engine feature for Nightly users only. r=johannh

Comment 4

[Mike de Boer [:mikedeboer]]

How on earth did this happen?!? Must've been a bad merge(?)

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 9104769 [details]
Bug 1592134 - Turn on the display of default private search engine feature for Nightly users only. r?mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: Private browsing wasn't disabled as per bug 1590775. The wrong thing got disabled.

We really don't know how this happened, but we both must have missed the pref being wrong somehow.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pref-only ifdef changes - reverting one to what it was previously, and this time disabling the correct preference for beta (browser.search.separatePrivateDefault.ui.enabled).
• String changes made/needed: none

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7290b4ea908c

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9104769 [details]
Bug 1592134 - Turn on the display of default private search engine feature for Nightly users only. r?mikedeboer

Low risk, uplift approved for 71 beta 6, thanks.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aecc033327a3