1592150 - Make partial updates with WebRender OS compositor work on macOS

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Use NextSurfaceAsDrawTarget in nsChildView.

Depends on D50726

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Track the nsChildView invalid region inside nsChildView, rather than on the layer. r=jrmuizel

Depends on D50876

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Change NextSurface APIs to accept a dirty region, and remove the public method InvalidateRegionThroughoutSwapchain. r=jrmuizel

Depends on D50877

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - wip

Depends on D50878

Comment 5

[Phabricator Automation]

Comment on attachment 9104789 [details]
Bug 1592150 - Use NextSurfaceAsDrawTarget in nsChildView.

Revision D50876 was moved to bug 1593325. Setting attachment 9104789 [details] to obsolete.

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Bake the layer size and its opaqueness into the layer, don't allow mutating it. r=jrmuizel

These settings are now supplied during layer creation and never change.
This aligns the NativeLayer API with DirectComposition's capabilities. It also
simplifies swap chain management.

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Remove unused SurfaceRegistry API. r=jrmuizel

Depends on D50878

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Move a step in the NativeLayerCA swap chain from mSurfaces to a new field called mFrontSurface. r=jrmuizel

This gives us easy access to a surface that has valid content. In the next patch,
we will use this surface to copy valid content from.

Depends on D51758

Comment 9

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Make NativeLayer::NextSurfaceAs* copy existing drawing from previous buffers so that only the update region needs to be drawn. r=jrmuizel

Depends on D51759

Comment 10

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Remove CurrentSurfaceInvalidRegion(). Callers now always just repaint the update region that they supplied. r=jrmuizel

Depends on D51760

Comment 11

[Markus Stange [:mstange]]

Attachment: Bug 1592150 - Enable support for partial updates in the WebRender OS compositor on macOS. r=jrmuizel

Depends on D51761

Comment 12

[Phabricator Automation]

Comment on attachment 9106422 [details]
Bug 1592150 - Bake the layer size and its opaqueness into the layer, don't allow mutating it. r=jrmuizel

Revision D51757 was moved to bug 1594950. Setting attachment 9106422 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9104790 [details]
Bug 1592150 - Track the nsChildView invalid region inside nsChildView, rather than on the layer. r=jrmuizel

Revision D50877 was moved to bug 1594950. Setting attachment 9104790 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9104791 [details]
Bug 1592150 - Change NextSurface APIs to accept a dirty region, and remove the public method InvalidateRegionThroughoutSwapchain. r=jrmuizel

Revision D50878 was moved to bug 1594950. Setting attachment 9104791 [details] to obsolete.

Comment 15

[Phabricator Automation]

Comment on attachment 9106423 [details]
Bug 1592150 - Remove unused SurfaceRegistry API. r=jrmuizel

Revision D51758 was moved to bug 1594950. Setting attachment 9106423 [details] to obsolete.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/292ede718577
Move a step in the NativeLayerCA swap chain from mSurfaces to a new field called mFrontSurface. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/ffcddfbaf321
Make NativeLayer::NextSurfaceAs* copy existing drawing from previous buffers so that only the update region needs to be drawn. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/1af8d457ec99
Remove CurrentSurfaceInvalidRegion(). Callers now always just repaint the update region that they supplied. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/8ae9d7dc86f2
Enable support for partial updates in the WebRender OS compositor on macOS. r=jrmuizel

Comment 17

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/292ede718577
https://hg.mozilla.org/mozilla-central/rev/ffcddfbaf321
https://hg.mozilla.org/mozilla-central/rev/1af8d457ec99
https://hg.mozilla.org/mozilla-central/rev/8ae9d7dc86f2