Closed Bug 1592016 Opened 1 year ago Closed 7 months ago

Enable gfx.webrender.compositor by default on macOS

Categories

(Core :: Graphics: WebRender, enhancement, P3)

All
macOS
enhancement

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

(Depends on 1 open bug, Blocks 3 open bugs)

Details

(Whiteboard: wr-planning)

Attachments

(2 files)

Bug 1591523 will land a first implementation of the WebRender OS compositor but it'll still be off by default.

This bug tracks the issues that need to be fixed in order to turn it on by default.

Summary: Enable gfx.webrender.compositor by default → Enable gfx.webrender.compositor by default on macOS
Depends on: 1592026
Depends on: 1592031
Depends on: 1592150
Priority: -- → P3

To clarify: WebRender will still be off by default on macOS once this lands. The goal in this bug is just to enable more efficient WebRender for people who have turned on WebRender manually.

Depends on: 1592388
Depends on: 1592739
Blocks: 1585856
Depends on: 1599609
No longer blocks: 1585856
Blocks: wr-mac
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Depends on: 1606631
Depends on: 1606685
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/099d6c72046d
Enable gfx.webrender.compositor by default on macOS. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Adding to Nightly 74 release notes as "The OS compositor has been enabled for macOS when WebRender is enabled"

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?

Bug 1592739 is being backed out for causing regressions, so this needs to be disabled as well.

https://hg.mozilla.org/integration/autoland/rev/2136aaa9de33

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla74 → ---

Note removed from beta release notes

Please re-nominate when the status of this bug changes.

relnote-firefox: ? → ---
Whiteboard: wr-planning
No longer depends on: 1617088
No longer depends on: 1617090

This causes test_menulist_position.xhtml to fail pretty consistently with "Labels vertically aligned for index 6" in M-1proc(c1). Not sure why, I'll look into it. It could be a fluke.

Nevermind, that failure is from bug 1624599.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/e2390cba7abf
Enable gfx.webrender.compositor by default on macOS. r=jrmuizel
Status: REOPENED → RESOLVED
Closed: 1 year ago7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
No longer depends on: 1592031
You need to log in before you can comment on or make changes to this bug.