1592016 - Enable gfx.webrender.compositor by default on macOS

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Markus Stange [:mstange]]

Bug 1591523 will land a first implementation of the WebRender OS compositor but it'll still be off by default.

This bug tracks the issues that need to be fixed in order to turn it on by default.

Comment 1

[Markus Stange [:mstange]]

To clarify: WebRender will still be off by default on macOS once this lands. The goal in this bug is just to enable more efficient WebRender for people who have turned on WebRender manually.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1592016 - Enable gfx.webrender.compositor by default on macOS. r=jrmuizel

Depends on D57070

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/099d6c72046d
Enable gfx.webrender.compositor by default on macOS. r=jrmuizel

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/099d6c72046d

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Adding to Nightly 74 release notes as "The OS compositor has been enabled for macOS when WebRender is enabled"

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 7

[Julien Cristau [:jcristau]]

Attachment: Backed out changeset 099d6c72046d (bug 1592016) as it depends on bug 1592739. a=backout

Comment 8

[Julien Cristau [:jcristau]]

Bug 1592739 is being backed out for causing regressions, so this needs to be disabled as well.

https://hg.mozilla.org/integration/autoland/rev/2136aaa9de33

Comment 9

[Julien Cristau [:jcristau]]

And on beta: https://hg.mozilla.org/releases/mozilla-beta/rev/30f86efe77d8b6807d331a62cf8189b5a2dc7503

Comment 10

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/2136aaa9de33

Comment 11

[Pascal Chevrel:pascalc]

Note removed from beta release notes

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please re-nominate when the status of this bug changes.

Comment 13

[Markus Stange [:mstange]]

This causes test_menulist_position.xhtml to fail pretty consistently with "Labels vertically aligned for index 6" in M-1proc(c1). Not sure why, I'll look into it. It could be a fluke.

Comment 14

[Markus Stange [:mstange]]

Nevermind, that failure is from bug 1624599.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2390cba7abf
Enable gfx.webrender.compositor by default on macOS. r=jrmuizel

Comment 16

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e2390cba7abf