Closed Bug 1592268 Opened 4 years ago Closed 4 years ago

Bookmark animation is not displayed in about:newtab

Categories

(Firefox :: Bookmarks & History, defect, P2)

Product:
Firefox
Component:
Bookmarks & History
Platform:
Desktop
All
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 72
Iteration:
72.2 - Nov 4 - 17
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 --- verified

People

(Reporter: Gabi, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

newtab-bookmark.gif
883.45 KB, image/gif
Details
Bug 1592268 - Make the permanent search icon a bookmarks doorhanger anchor. r?mak
47 bytes, text/x-phabricator-request
Details | Review
Attached image newtab-bookmark.gif —

  • [Affected versions]:
    Fx 72.0a1

  • [Affected platforms]:
    macOS 10.14
    Ubuntu 16.04
    Windows 10x64

  • [Steps to reproduce]:

  1. Launch Firefox
  2. Open a new tab page
  3. Ctrl+D or right click the star shaped icon from menu to bookmark page

  • [Expected result]:
    New Bookmark popup should be displayed with the bookmarks animation

  • [Actual result]:
    No popup is displayed when bookmarking about:newtab page.
    Page is shown in Bookmarks, unable to delete it from bookmarks.
    See the attached gif.

Regression: pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef86e43a743933acf8dc1bbc5a49809e9fb61467&tochange=8e8e5bb63105fd26d10f7cba6adf85a606bceaf0
Found commit message: Bug 1589836 - Add permanent search icon in front of the megabar. r=ad

Has Regression Range: --- → yes
Has STR: --- → yes
Blocks: urlbar-update-1
Regressed by: 1589836
Priority: -- → P3
Priority: P3 → P2
Points: --- → 2
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 72.2 - Nov 4 - 17
Points: 2 → 1
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6fa62187db7
Make the permanent search icon a bookmarks doorhanger anchor. r=mak

https://hg.mozilla.org/mozilla-central/rev/e6fa62187db7

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Flags: qe-verify+

Hi, this issue is Verified as fixed in Fx 72.0.2 (20200117190643).

Status: RESOLVED → VERIFIED
status-firefox72: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.