159230 - Should be able to bookmark a page without an intermediate dialog

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Simon Fraser [no longer active]]

Bookmarking a page is one of those things that needs to be a 1-click operation.
We're making it extra-complicated by showing the sheet dialog that asks you
where you want to put the bookmark; I'm sure most users will just choose the
default location.

We should just append the bookmark to the end of the list (or have a 'new items'
folder that defaults to the root). Maybe holding down the option key should show
the intermediate sheet dialog.

Comment 1

[saari (gone)]

If I can drag the proxy icon into the bookmark sidebar and personal toolbar, and
organize that way, perhaps that is what we should advocate for more advanced
bookmark management? 

I tend to agree with you, I almost never do anything other than bonk the okay
button on that dialog.

Comment 2

[Mike Pinkerton (not reading bugmail)]

you ask, you win! -> smfr

Comment 3

[john]

I actually like the current behaviour - it *forces* me to keep my bookmarks
organized & meaningful. It's such a chore to go back & file bookmarks later that
I never do it, and end up with a mess.

Maybe make a sticky preference for whether or not to show the sheet, but I
wouldn't want to have to hold option each time.

Comment 4

[Simon Fraser [no longer active]]

*** Bug 184996 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

bug 184996 suggested shift-command-D as a shortcut to add a bookmark without the
sheet.

Comment 6

[Steve Smart]

I think the current behavior is good, as webpage titles typically make poor
bookmark titles. I would simply have the current "Add Page to Bookmarks...    
command-D" command change to "Add Page to Bookmarks        option-command-D" in
the same way that "Empty Trash...     shift-command-delete" changes to "Empty
Trash        option-shift-command-delete" in the Finder.

The option key should be used for this shortcut, since it bypasses the dialog,
whereas shift-key shortcuts are for variants of the original command (e.g.
Print, cmd-P; Page Setup, shift-cmd-P).

Comment 7

[Stephane Moureau]

Option-Command-D is reserved to Show/Hide the Dock.
I find very annoying Apple uses so much shortcuts for 'useless' features,
leading to inconsistency in other programs.

Comment 8

[Steve Smart]

Totally forgot about that ;) I guess shift-cmd-D is our best option for this.

Comment 9

[S Woodside]

Mail.app shows the drawer if you drag a message over to the side and the drawer
isn't open. We might do the same thing with bookmarks (draggin from the location
bar). Still I like the current behaviour and use it to shorten the names of the
bookmarks to some mnemonic for me.

Comment 10

[Stephane Moureau]

Simon, that's another bug (drag-show drawer) you can fill it, AAHIG says it must
be like that.

Comment 11

[Simon Fraser [no longer active]]

*** Bug 155093 has been marked as a duplicate of this bug. ***

Comment 12

[Jasper]

This would be very good to have for 1.0.

Comment 13

[Aulia Masna]

I think the proposed behavior would correspond to downloading from links. When
you download a link target, you can either control click the link, select
"Download Link Target..." and use the resulting Save dialog box or you can
option click it and the target will be downloaded to the default download folder.

Comment 14

[Samuel Sidler (old account; do not CC)]

While this would be good to have for 1.0, the other applicable bug (which is bug
219056, mentioned in comment 13) for downloading with one click is targeted for
1.1. Should this be moved there as well? Or both to 1.0?

Comment 15

[James Wheare]

Slightly related, though maybe a new bug. Could the location selected in the "Create in" drop down menu be remembered. I never use the bookmark menu, prefering instead to keep stuff in the bar, so it's a bit of a pain to always specify that in the drop down.

This is only a problem because I can't consistently just drag items to the bar as documented in bug 223315

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #15)
> Slightly related, though maybe a new bug. Could the location selected in the
> "Create in" drop down menu be remembered. I never use the bookmark menu,
> prefering instead to keep stuff in the bar, so it's a bit of a pain to always
> specify that in the drop down.

We used to remember the folder; see bug 287708 comment 6.  If that's not the case any more, that's a regression and needs to be a separate bug.

Comment 17

[James Wheare]

(In reply to comment #16)
> We used to remember the folder; see bug 287708 comment 6.  If that's not the
> case any more, that's a regression and needs to be a separate bug.

The folder is remembered but the memory doesn't persist when you restart Camino. New bug filed: bug 328737

Comment 18

[froodian (Ian Leue)]

If we do indeed make the non-intermediate case default, this should wait for bug 287708 to be usable for people (and so we don't get "hey.  where did my bookmark go?" when people can't find it in the menu).

Comment 19

[froodian (Ian Leue)]

Per status meeting, the default should be to have a dialog.  We'll keep Cmd-D for legacy, and move the official shortcuts to Cmd-K for "Add with dialog" and Cmd-K + modifier for "Add without dialog".

I propose using cmd-shift-K, so we can use cmd-opt-K for "Bookmark all tabs", which would reflect the Cmd-R situation.

Comment 20

[froodian (Ian Leue)]

The fix for this is in bug 275170

Comment 21

[froodian (Ian Leue)]

Fixed.

Comment 22

[Samuel Sidler (old account; do not CC)]

Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.