Make bookmarks bar the default collection selection on add bookmark dialog

VERIFIED FIXED in Camino1.5

Status

Camino Graveyard
Toolbars & Menus
--
enhancement
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: froodian (Ian Leue), Assigned: froodian (Ian Leue))

Tracking

(Blocks: 1 bug, {fixed1.8.1})

1.8 Branch
Camino1.5
PowerPC
Mac OS X
fixed1.8.1
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.81 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Per a status meeting, as a stop-gap measure for bug 287708 (and to allow dialog-less bookmarking to be useful), we should make the default selection of cmd-D the bookmarks bar (and not the bookmarks folder) when invoked for the first time after launch.
(Assignee)

Comment 1

11 years ago
Created attachment 235757 [details] [diff] [review]
Patch
Attachment #235757 - Flags: review?(mozilla)

Comment 2

11 years ago
Comment on attachment 235757 [details] [diff] [review]
Patch

r+ = me.
Attachment #235757 - Flags: review?(mozilla) → review+
(Assignee)

Updated

11 years ago
Attachment #235757 - Flags: superreview?(mikepinkerton)
Comment on attachment 235757 [details] [diff] [review]
Patch

sr=pink
Attachment #235757 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]

Comment 4

11 years ago
How long are we going to be stopping this gap? :-p Hopefully we get something finished before we ship another release version because this has the potential to annoy people who are used to the old behaviour.

cl

Comment 5

11 years ago
Comment on attachment 235757 [details] [diff] [review]
Patch

Your |bookmarkManager| variable could be used in more places in the same scope, where [BookmarkManager sharedBookmarkManager]| currently is. Reuse, reuse, reuse! :)
(Assignee)

Comment 6

11 years ago
Created attachment 236075 [details] [diff] [review]
Patch

Oops.  Yeah, I missed one.  Nice catch.
Attachment #235757 - Attachment is obsolete: true
(Assignee)

Comment 7

11 years ago
Checked in on trunk and 1.8branch.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]

Comment 8

11 years ago
@ comment #4


like me
Status: RESOLVED → VERIFIED

Comment 9

11 years ago
Camino should remember what I last selected in the bookmarks dialog pop up between launches of the application. Not just for the current session.

The new behavior (default to bookmarks bar) is very annoying, especially if you have a long bookmarks menu like I do. I forget that it doesn't save the selection between launches and end up putting all the bookmarks into the bookmarks bar, which I have hidden.
(In reply to comment #9)
> Camino should remember what I last selected in the bookmarks dialog pop up
> between launches of the application. Not just for the current session.

That's filed as bug 328737.

Comment 11

11 years ago
(In reply to comment #10)
> (In reply to comment #9)
> > Camino should remember what I last selected in the bookmarks dialog pop up
> > between launches of the application. Not just for the current session.

I am not surprised that people are complaining about the '"Add Bookmark" to Bookmark Bar policy' over-riding the user's wish!

A better stop gap measure would be to put New Bookmarks at the top of the Bookmark list, or in a dated folder at that place (much like the History list); or better still in an alternative Bookmark Bar labeled 'Incoming', from which they could be dragged to the "All Bookmarks" screen at the user's lesiure.

My Bookmark Bar is ten rows deep (owing to the lack of usability of the Bookmark menu and the "All Bookmarks" screen) and I have to keep it hidden: Adding bookmarks to /dev/null makes more sense than the existing policy, and I guess that this what many users are actually doing nowadays!

I expect that these ideas have been considered and rejected, but I ask: Would a patch to do this be considered? 

Comment 12

11 years ago
(In reply to comment #11)
> Would a patch to do this be considered? 

No. Bug 328737 is the right way to fix this.
You need to log in before you can comment on or make changes to this bug.