Open Bug 1592323 Opened 5 years ago Updated 2 months ago

Consider if SearchService._engines needs a better indexing mechanism, combine with __sortedEngines?

Categories

(Firefox :: Search, task, P3)

Product:
Firefox
Component:
Search
Type:
task
Points:
8

Tracking

()

People

(Reporter: standard8, Unassigned)

References

Details

(Whiteboard: [sng][search-tech-debt])

In bug 1577733 I am adding a lookup into this._engines based on the extension id and the locale (_getEngineByWebExtensionDetails).

We might want to consider changing this._engines to have a different indexing method other than the name.

This will be easier to reason about once we've removed the legacy configuration after modernisation ships.

In addition to the above, we should look at this.__sortedEngines as well - they're basically storing exactly the same thing, but one is sorted and one is not.

Summary: Consider if SearchService._engines needs a better indexing mechanism → Consider if SearchService._engines needs a better indexing mechanism, combine with __sortedEngines?
Blocks: post-modern-search-cleanup
Severity: normal → N/A
Points: --- → 8
Blocks: post-search-config-v2
No longer blocks: post-search-config-v2
Whiteboard: [sng][search-tech-debt]
You need to log in before you can comment on or make changes to this bug.