Make column pickers in the Address Book sticky/persistent (menu should behave like a panel, i.e. stay open for selecting multiple columns until user clicks outside or ESC)
Categories
(Thunderbird :: Address Book, enhancement, P5)
Tracking
(thunderbird_esr6870+ fixed, thunderbird71 fixed, thunderbird72 fixed)
People
(Reporter: tanstaafl, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
4.89 KB,
patch
|
Paenglab
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0
Steps to reproduce:
Went to confugure columns in the Address Book window
Actual results:
Discovered that bug 545906, that resolved this for the main Folder & Message list, didn't resolve it for the Address Book.
Expected results:
It would be resolved for all column pickers.
Comment 1•5 years ago
|
||
Alta88, can you work your magic here, too? Or Alex?
Comment 2•5 years ago
|
||
Since alta88 fixed bug 545906, I think he knows better where to touch things.
Let me know if you can take care of this, thanks.
Comment 4•5 years ago
|
||
I can do it, looks like we need to add a bunch of closemenu="none"
to the AB tree columns like here:
https://hg.mozilla.org/comm-central/rev/055cf553a73e#l1.10
Assignee | ||
Comment 5•5 years ago
|
||
Jörg, you wrote you want do it but you have so many other things to do. So I decided to it.
Comment 6•5 years ago
|
||
Comment on attachment 9105604 [details] [diff] [review] 1592393-AB-column-picker.patch Review of attachment 9105604 [details] [diff] [review]: ----------------------------------------------------------------- Hmm, you beat me to it. I was thinking about the bug, and then got side-tracked, like always. I haven't tested it, but it looks right and I'm sure you have. ::: mail/components/addrbook/content/addressbook.xul @@ +804,5 @@ > hidden="true" > label="&Addrbook.label;"/> > <!-- LOCALIZATION NOTE: _PhoneticName may be enabled for Japanese builds. --> > <!-- > <treecol id="_PhoneticName" Let's add it here, too.
Assignee | ||
Comment 7•5 years ago
|
||
Added to the treecol id="_PhoneticName"
.
Comment 8•5 years ago
|
||
Comment on attachment 9105610 [details] [diff] [review] 1592393-AB-column-picker.patch Sorry, that was in a comment, but better to be consistent.
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4c51d0d531e5
Make the address book tree column picker popup stay open for multiple selects. r=jorgk
Reporter | ||
Comment 11•5 years ago
|
||
So, to be clear - is this supposed to be fixed in 68.2.1? I'm guessing no, since mine isn't...
Comment 12•5 years ago
|
||
No. We're do you see a comment mentioning 68.2.1 or later?
Reporter | ||
Comment 13•5 years ago
|
||
Weird, I could have sworn I read a comment (via email) that this was fixed in 68.2.1...
Sorry, should have looked more closely.
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
TB 71 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/7f1d0247bd5b2355133aa8d9b18bdb539873e39a
Description
•