1592419 - Reject duplicate toolchain aliases

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P2)

Description

[Chris Manchester (limited bugmail, email directly)]

It seems like things like bug 1592402 should be actively rejected by the taskgraph.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

It appears we had a check for this, but it was removed as part of bug 1573435.

Comment 2

[Justin Wood (:Callek)]

Attachment: Bug 1592419 - Reject duplicate toolchain aliases. r=chmanchester

With this patch applied but Bug 1592402 not fixed, I got:

Traceback (most recent call last):
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/mach_commands.py", line 379, in show_taskgraph
    tg = getattr(tgg, graph_attr)
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/generator.py", line 151, in full_task_graph
    return self._run_until('full_task_graph')
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/generator.py", line 351, in _run_until
    k, v = self._run.next()
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/generator.py", line 287, in _run
    yield verifications('full_task_graph', full_task_graph, graph_config)
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/util/verify.py", line 36, in __call__
    graph.for_each_task(verification, scratch_pad=scratch_pad, graph_config=graph_config)
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/taskgraph.py", line 31, in for_each_task
    f(task, self, *args, **kwargs)
  File "/home/callek/mozilla/hg/mozilla-central/taskcluster/taskgraph/util/verify.py", line 240, in verify_task_graph_symbol
    key,
Exception: Duplicate toolchain-alias in tasks `toolchain-linux64-clang-9`and `toolchain-linux64-clang-9-cross`: linux64-clang

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb90d8c06180
Reject duplicate toolchain aliases. r=tomprince

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fb90d8c06180