1592431 - [jsdbg2] Debugger.Frame should report script, callee, bytecode offset for suspended generator frames

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Jim Blandy :jimb]

At the moment, a Debugger.Frame for a suspended generator or async call can't report any information about the suspended call, but the generator object referred to by the frame's GeneratorInfo structure has a lot of information.

In particular, to obtain stack traces, we need to be able to obtain the callee and the bytecode offset within that callee. These are available via the CALLEE_SLOT and RESUME_INDEX_SLOT reserved slots in any AbstractGeneratorObject.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1592431 - Part 1: Rename Debugger.Frame.prototype.live to .onStack. r=jimb!

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1592431 - Part 2: Introduce Debugger.Frame.prototype.terminated to check state. r=jimb!

Depends on D54488

Comment 3

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1592431 - Part 3: Support .script on suspended generator frames. r=jimb!

Depends on D54489

Comment 4

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1592431 - Part 4: Support .callee on suspended generator frames. r=jimb!

Depends on D54490

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1592431 - Part 5: Support .offset on suspended generator frames. r=jimb!

Depends on D54491

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ccdf607f39d
Part 1: Rename Debugger.Frame.prototype.live to .onStack. r=jimb
https://hg.mozilla.org/integration/autoland/rev/c54ca77cc17b
Part 2: Introduce Debugger.Frame.prototype.terminated to check state. r=jimb
https://hg.mozilla.org/integration/autoland/rev/b6f777ff55d5
Part 3: Support .script on suspended generator frames. r=jimb
https://hg.mozilla.org/integration/autoland/rev/3a3b4395b1da
Part 4: Support .callee on suspended generator frames. r=jimb
https://hg.mozilla.org/integration/autoland/rev/664889e8c4a6
Part 5: Support .offset on suspended generator frames. r=jimb

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3ccdf607f39d
https://hg.mozilla.org/mozilla-central/rev/c54ca77cc17b
https://hg.mozilla.org/mozilla-central/rev/b6f777ff55d5
https://hg.mozilla.org/mozilla-central/rev/3a3b4395b1da
https://hg.mozilla.org/mozilla-central/rev/664889e8c4a6