1600204 - [jsdbg2] Debugger.Frame should support .type and .constructing for suspended generator frames and remove .generator

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Logan Smyth [:loganfsmyth]]

These 2 are easy to support on suspended frames, so we might as well support them, and generator is just duplicating logic implemented elsewhere.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1600204 - Part 1: Support .type on suspended generator frames. r=jimb!

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1600204 - Part 2: Remove Debugger.Frame.prototype.generator since it is already on script. r=jimb!

Depends on D55231

Comment 3

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1600204 - Part 3: Support .constructing on suspended generator frames. r=jimb!

Depends on D55232

Comment 4

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1600204 - Part 4: Remove documentation for unimplemented .depth property. r=jimb!

Depends on D55233

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1600204 - Part 5: Support .environment on suspended generator frames. r=jimb!

Depends on D55234

Comment 6

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1600204 - Part 6: Support .older on suspended generator frames. r=jimb!

Depends on D55235

Comment 7

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1600204 - Part 7: Support .this on suspended generator frames. r=jimb!

Depends on D55236

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d70ec1e79887
Part 1: Support .type on suspended generator frames. r=jimb
https://hg.mozilla.org/integration/autoland/rev/73c33bf110d6
Part 2: Remove Debugger.Frame.prototype.generator since it is already on script. r=jimb
https://hg.mozilla.org/integration/autoland/rev/2828f072134e
Part 3: Support .constructing on suspended generator frames. r=jimb
https://hg.mozilla.org/integration/autoland/rev/39d1ae1352b3
Part 4: Remove documentation for unimplemented .depth property. r=jimb
https://hg.mozilla.org/integration/autoland/rev/ea1bb2f0fd39
Part 5: Support .environment on suspended generator frames. r=jimb
https://hg.mozilla.org/integration/autoland/rev/fa46d8caefde
Part 6: Support .older on suspended generator frames. r=jimb
https://hg.mozilla.org/integration/autoland/rev/31d14cf1975c
Part 7: Support .this on suspended generator frames. r=jimb

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d70ec1e79887
https://hg.mozilla.org/mozilla-central/rev/73c33bf110d6
https://hg.mozilla.org/mozilla-central/rev/2828f072134e
https://hg.mozilla.org/mozilla-central/rev/39d1ae1352b3
https://hg.mozilla.org/mozilla-central/rev/ea1bb2f0fd39
https://hg.mozilla.org/mozilla-central/rev/fa46d8caefde
https://hg.mozilla.org/mozilla-central/rev/31d14cf1975c