1592474 - Add some heuristics to disable scroll anchoring in pathological cases.

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

The idea of these are not to penalize legit uses of scroll anchoring, and catching pathological cases fast.

The current algorithm I thought of is just whether the average of all the consecutive scroll anchoring adjustments is less than a given threshold.

If the average adjustment is close to zero and the user is not scrolling, it means that we're not making much progress.

Exact number may need tuning, let me know if you want it nightly-and-early-beta-only for now or something.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1592474 - Add some heuristics to disable scroll anchoring in pathological cases.

The idea of these are not to penalize legit uses of scroll anchoring, and
catching pathological cases fast.

The current algorithm I thought of is just whether the average of all the
consecutive scroll anchoring adjustments is less than a given threshold.

If the average adjustment is close to zero and the user is not scrolling, it
means that we're not making much progress.

It is important that zero adjustments don't get counted, since those are common
during window resizes and don't have side-effects anyway.

Exact number may need tuning, let me know if you want it
nightly-and-early-beta-only for now or something.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1592474 - Report a console warning when we disable scroll anchoring on a scroller.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1592474 - Share code between ScrollAnchorContainer::{Destroy,InvalidateAnchor}.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49e2e43d3252
Share code between ScrollAnchorContainer::{Destroy,InvalidateAnchor}. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/b757148cddfd
Add some heuristics to disable scroll anchoring in pathological cases. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/08338f14d554
Report a console warning when we disable scroll anchoring on a scroller. r=dholbert,flod

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/49e2e43d3252
https://hg.mozilla.org/mozilla-central/rev/b757148cddfd
https://hg.mozilla.org/mozilla-central/rev/08338f14d554