Closed
Bug 1592513
Opened 5 years ago
Closed 5 years ago
node actor should not require DOMHelpers from devtools/client
Categories
(DevTools :: Inspector, task, P3)
DevTools
Inspector
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(2 files)
In Bug 1590050, I started using DOMHelpers to wait for iframes to load in the node actor, but DOMHelpers lives in devtools/client, so it should not be used in devtools/server.
Bug 1591013 adds a linter to avoid such issues and I noticed this when attempting to land it for the first time.
|
Assignee | |
Comment 1•5 years ago
|
||
Since I started using this helper in devtools/server/ (Node actor), the file needs to move outside of devtools/client
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D51053
eslint validation was more relaxed in the previous location of this helper, we need to fix some violations.
|
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P3
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2352f3507184
Move DOMHelpers.jsm from devtools/client/shared/ to devtools/shared/ r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/80fef7621cb0
Fix eslint errors in DOMHelpers.jsm r=rcaliman
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2352f3507184
https://hg.mozilla.org/mozilla-central/rev/80fef7621cb0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
|
||
Comment 5•5 years ago
|
||
| bugherder landing | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•