1590050 - Preserve selected node in markup view when reloading page with iframe

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

The inspector currently attempts to reselect the selected node in the markup view when reloading the page.

It does so by keeping track of the CSS selector of the currently selected element.
However this doesn't support elements nested in iframes or webcomponents.

We would like to introduce iframes in our DAMP tests. Supporting this feature would make the inspector tests more relevant when using an iframe.

See Bug 1589011

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1590050 - Extract DevTools walker fronts & specs to dedicated files

Cleanup before adding more content to the walker front

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1590050 - Move findNodeFront helper to walker front

Depends on D49938

This helper can be moved on the walker front and will be useful to find the selected node front after a page reload

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1590050 - Walker findNodeFront should use selectors relevant to its rootNode

Depends on D49939

Small fix on the findNodeFront helper. The walker should be able to calculate its depth without relying on consumers to remove selectors from the array passed to findNodeFront.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1590050 - Preserve markup view selection in iframes after reload

Depends on D49940

To support this feature we perform two main changes

• the node actor exposes a getAllSelectors method, and the inspector now stores all selectors rather than just one
• the node actor exposes a waitForFrameLoad method, and the walkerFront findNodeFront helper uses it to make sure frames are loaded before querying a selector

Also added a test

Comment 5

[Julian Descottes [:jdescottes]]

try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ca6d9340f8ade22c4441a65100bb532ba0887f0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3354b8426f38
Extract DevTools walker fronts & specs to dedicated files r=gl
https://hg.mozilla.org/integration/autoland/rev/35bb8f4411e5
Move findNodeFront helper to walker front r=gl
https://hg.mozilla.org/integration/autoland/rev/8a9767a9ed77
Walker findNodeFront should use selectors relevant to its rootNode r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/78b0791bfb15
Preserve markup view selection in iframes after reload r=rcaliman,gl

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3354b8426f38
https://hg.mozilla.org/mozilla-central/rev/35bb8f4411e5
https://hg.mozilla.org/mozilla-central/rev/8a9767a9ed77
https://hg.mozilla.org/mozilla-central/rev/78b0791bfb15