1592535 - Show a clickable stack trace in the cause column

Reporter

Description

•

5 years ago

Bug 1134073 initially landed a cause column with a stack trace. In the panel rewrite, it seems to have dropped off. It is extremely useful see not just which script caused an XHR but also which CSS file caused an image load or CSS import.

:Harald Kirschner :digitarald

Reporter

Updated

•

5 years ago

Blocks: netmonitor-initiator

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 1

•

5 years ago

Some instructions for anyone interested in fixing this:

The cause column is rendered here:
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/devtools/client/netmonitor/src/components/RequestListColumnCause.js#25
The stacktrace is rendered in Stack Trace panel here (if available)
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/devtools/client/netmonitor/src/components/StackTracePanel.js#58

Important is that the stack-trace info needs to be fetched from the server explicitly, see this place
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/devtools/client/netmonitor/src/components/StackTracePanel.js#42

fetchNetworkUpdatePacket(connector.requestData, request, ["stackTrace"]);

Since the Cause column is visible by default, it could be perf problem to fetch the stack-trace info for every request.
We need to display just the last frame in the column so, we should rather send the one frame by default as part of an existing packet.

Perhaps, we could send it as part of the networkEvent packet here:
https://searchfox.org/mozilla-central/rev/9df2ccc256fe54c314b34e52920471a0d04b283e/devtools/server/actors/network-monitor/network-monitor.js#299-310

At this point we are setting event.cause.stacktrace only, but we could perhaps set also event.cause.lastFrame?

I am marking this one as good-first-bug, but it feels more like good-second-bug

Honza

Keywords: good-first-bug

:Harald Kirschner :digitarald

Reporter

Comment 2

•

4 years ago

We discussed that it's more helpful to initially land this as new column ("Stack" would be in line with the details tab, or "Initiatior" in line with Chrome). Cause is separate information that should be retained and potentially merged.

Jan Honza Odvarko [:Honza] (always need-info? me)

Comment 3

•

4 years ago

CCing Hubert on this bug report ...

Honza

:Harald Kirschner :digitarald

Reporter

Updated

•

4 years ago

Blocks: 1607917

:Harald Kirschner :digitarald

Reporter

Comment 4

•

4 years ago

An extension of this (aka follow up bug) would be preview of the full stack trace in a tooltip --> bug 1607917.

Jan Honza Odvarko [:Honza] (always need-info? me)

Updated

•

4 years ago

Blocks: netmonitor-columns

Bryan Kok [:transfusion]

Assignee

Comment 5

•

4 years ago

Attached file Bug 1592535 - Add a column displaying the last frame in the stack trace info if it exists r=Harald,Honza — Details

Phabricator Automation

Updated

•

4 years ago

Assignee: nobody → bryan.wyern1

Status: NEW → ASSIGNED

Pulsebot

Comment 6

•

4 years ago

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efefdcf32ad5
Add a column displaying the last frame in the stack trace info if it exists r=Harald,Honza

Bogdan Tara[:bogdan_tara | bogdant]

Comment 7

•

4 years ago

Backed out changeset efefdcf32ad5 (Bug 1592535) for browser_net_filter-autocomplete.js & browser_net_headers-resize.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-devtools-chrome-e10s-4%2Cm%28dt4%29&fromchange=40ee37b0fda9f80897b27d1f40bf497de442d8cf&tochange=21663b921f6ded1d1408eb8ca71d571fdf26e48b&selectedJob=288931110

Backout link: https://hg.mozilla.org/integration/autoland/rev/21663b921f6ded1d1408eb8ca71d571fdf26e48b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288931110&repo=autoland&lineNumber=3444

[task 2020-02-14T13:50:01.159Z] 13:50:01     INFO - TEST-START | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js
[task 2020-02-14T13:50:09.012Z] 13:50:09     INFO - TEST-INFO | started process screentopng
[task 2020-02-14T13:50:09.238Z] 13:50:09     INFO - TEST-INFO | screentopng: exit 0
[task 2020-02-14T13:50:09.238Z] 13:50:09     INFO - Buffered messages logged at 13:50:01
[task 2020-02-14T13:50:09.238Z] 13:50:09     INFO - Entering test bound 
[task 2020-02-14T13:50:09.239Z] 13:50:09     INFO - Initializing a network monitor pane.
[task 2020-02-14T13:50:09.240Z] 13:50:09     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/netmonitor/test/html_filter-test-page.html
[task 2020-02-14T13:50:09.240Z] 13:50:09     INFO - Tab added and finished loading
[task 2020-02-14T13:50:09.241Z] 13:50:09     INFO - Net tab added successfully: http://example.com/browser/devtools/client/netmonitor/test/html_filter-test-page.html
[task 2020-02-14T13:50:09.241Z] 13:50:09     INFO - Buffered messages logged at 13:50:02
[task 2020-02-14T13:50:09.241Z] 13:50:09     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2020-02-14T13:50:09.242Z] 13:50:09     INFO - Buffered messages logged at 13:50:03
[task 2020-02-14T13:50:09.243Z] 13:50:09     INFO - Network monitor pane shown successfully.
[task 2020-02-14T13:50:09.244Z] 13:50:09     INFO - Disabling cache and reloading page.
[task 2020-02-14T13:50:09.245Z] 13:50:09     INFO - Request server0.conn54.netEvent4 for http://example.com/browser/devtools/client/netmonitor/test/html_filter-test-page.html done
[task 2020-02-14T13:50:09.250Z] 13:50:09     INFO - All requests finished
[task 2020-02-14T13:50:09.250Z] 13:50:09     INFO - Buffered messages logged at 13:50:04
[task 2020-02-14T13:50:09.251Z] 13:50:09     INFO - Console message: [JavaScript Warning: "Relative positioning of table rows and row groups is now supported. This site may need to be updated because it may depend on this feature having no effect." {file: "resource://devtools/client/netmonitor/src/components/request-list/RequestListHeader.js" line: 450}]
[task 2020-02-14T13:50:09.252Z] 13:50:09     INFO - Got marker: dom-interactive
[task 2020-02-14T13:50:09.253Z] 13:50:09     INFO - Got marker: dom-complete
[task 2020-02-14T13:50:09.253Z] 13:50:09     INFO - Got two timeline markers, done waiting
[task 2020-02-14T13:50:09.254Z] 13:50:09     INFO - Cache disabled when the current and all future toolboxes are open.
[task 2020-02-14T13:50:09.258Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Request to reconfigure the tab was recorded. - 
[task 2020-02-14T13:50:09.259Z] 13:50:09     INFO - Clearing requests in the console client.
[task 2020-02-14T13:50:09.259Z] 13:50:09     INFO - Clearing requests in the UI.
[task 2020-02-14T13:50:09.259Z] 13:50:09     INFO - Starting test... 
[task 2020-02-14T13:50:09.260Z] 13:50:09     INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/shared/test/frame-script-utils.js
[task 2020-02-14T13:50:09.260Z] 13:50:09     INFO - Performing requests in the context of the content.
[task 2020-02-14T13:50:09.260Z] 13:50:09     INFO - > Network event progress: NetworkEvent: 1/10, PayloadReady: 0/10, got NetMonitor:NetworkEvent for server0.conn54.netEvent23
...
[task 2020-02-14T13:50:09.280Z] 13:50:09     INFO - > Network event progress: NetworkEvent: 10/10, PayloadReady: 10/10, got NetMonitor:PayloadReady for server0.conn54.netEvent223
[task 2020-02-14T13:50:09.281Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Autocomplete Popup still hidden - 
[task 2020-02-14T13:50:09.281Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Autocomplete Popup Created - 
[task 2020-02-14T13:50:09.282Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:200 found - 
[task 2020-02-14T13:50:09.283Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:201 found - 
[task 2020-02-14T13:50:09.283Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:202 found - 
[task 2020-02-14T13:50:09.283Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:203 found - 
[task 2020-02-14T13:50:09.284Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:204 found - 
[task 2020-02-14T13:50:09.284Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:205 found - 
[task 2020-02-14T13:50:09.284Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:206 found - 
[task 2020-02-14T13:50:09.284Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Value correctly set after Enter - 
[task 2020-02-14T13:50:09.285Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Autocomplete Popup hidden after keyboard Enter key - 
[task 2020-02-14T13:50:09.285Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Autocomplete Popup Created - 
[task 2020-02-14T13:50:09.286Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | scheme: found - 
[task 2020-02-14T13:50:09.286Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | set-cookie-domain: found - 
[task 2020-02-14T13:50:09.287Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | set-cookie-name: found - 
[task 2020-02-14T13:50:09.287Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | set-cookie-value: found - 
[task 2020-02-14T13:50:09.288Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | size: found - 
[task 2020-02-14T13:50:09.289Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code: found - 
[task 2020-02-14T13:50:09.289Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | scheme: found - 
[task 2020-02-14T13:50:09.289Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Autocomplete Popup alive with content values - 
[task 2020-02-14T13:50:09.291Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | scheme:http found - 
[task 2020-02-14T13:50:09.291Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Value correctly set after Enter - 
[task 2020-02-14T13:50:09.291Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Autocomplete Popup hidden after keyboard Enter key - 
[task 2020-02-14T13:50:09.291Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | protocol: found - 
[task 2020-02-14T13:50:09.292Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Tokenized click generates correct value in input box - 
[task 2020-02-14T13:50:09.292Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:200 found - 
[task 2020-02-14T13:50:09.293Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | status-code:304 found - 
[task 2020-02-14T13:50:09.294Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | Typing the exact value closes autocomplete - 
[task 2020-02-14T13:50:09.294Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | mime-type:text/css found - 
[task 2020-02-14T13:50:09.294Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | mime-type:text/html found - 
[task 2020-02-14T13:50:09.294Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | mime-type:text/plain found - 
[task 2020-02-14T13:50:09.295Z] 13:50:09     INFO - Buffered messages logged at 13:50:09
[task 2020-02-14T13:50:09.296Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | -cause: found - 
[task 2020-02-14T13:50:09.296Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | -domain: found - 
[task 2020-02-14T13:50:09.296Z] 13:50:09     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | -has-response-header: found - 
[task 2020-02-14T13:50:09.297Z] 13:50:09     INFO - Buffered messages finished
[task 2020-02-14T13:50:09.298Z] 13:50:09     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | -is: found - Got -initiator:, expected -is:
[task 2020-02-14T13:50:09.298Z] 13:50:09     INFO - Stack trace:
[task 2020-02-14T13:50:09.298Z] 13:50:09     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-02-14T13:50:09.298Z] 13:50:09     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_filter-autocomplete.js:testAutocompleteContents/<:30
[task 2020-02-14T13:50:09.298Z] 13:50:09     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_filter-autocomplete.js:testAutocompleteContents:29
[task 2020-02-14T13:50:09.299Z] 13:50:09     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_filter-autocomplete.js:null:174
[task 2020-02-14T13:50:09.299Z] 13:50:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-14T13:50:09.299Z] 13:50:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-14T13:50:09.299Z] 13:50:09     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-14T13:50:09.299Z] 13:50:09     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914
[task 2020-02-14T13:50:09.300Z] 13:50:09     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-14T13:50:09.300Z] 13:50:09     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_filter-autocomplete.js | -larger-than: found - Got -is:, expected -larger-than:
[task 2020-02-14T13:50:09.300Z] 13:50:09     INFO - Stack trace:
[task 2020-02-14T13:50:09.300Z] 13:50:09     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-02-14T13:50:09.300Z] 13:50:09     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_filter-autocomplete.js:testAutocompleteContents/<:30
[task 2020-02-14T13:50:09.301Z] 13:50:09     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_filter-autocomplete.js:testAutocompleteContents:29
[task 2020-02-14T13:50:09.301Z] 13:50:09     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_filter-autocomplete.js:null:174
[task 2020-02-14T13:50:09.301Z] 13:50:09     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
...
...
[task 2020-02-14T13:51:38.622Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Request to reconfigure the tab was recorded. - 
[task 2020-02-14T13:51:38.623Z] 13:51:38     INFO - Clearing requests in the console client.
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - Clearing requests in the UI.
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - Starting test... 
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 0/1, got NetMonitor:NetworkEvent for server0.conn4.netEvent23
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - > Network event progress: NetworkEvent: 1/1, PayloadReady: 1/1, got NetMonitor:PayloadReady for server0.conn4.netEvent23
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - Resize file & check changed prefs...
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column file has expected size. - 
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - Buffered messages finished
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column contentSize has expected size. - Got 4, expected 10
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - Stack trace:
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_headers-resize.js:checkColumnsData:203
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_headers-resize.js:null:46
[task 2020-02-14T13:51:38.625Z] 13:51:38     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-14T13:51:38.626Z] 13:51:38     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-14T13:51:38.626Z] 13:51:38     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-14T13:51:38.626Z] 13:51:38     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914
[task 2020-02-14T13:51:38.626Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | All visible columns cover 100%. - 
[task 2020-02-14T13:51:38.626Z] 13:51:38     INFO - Resize waterfall & check changed prefs...
[task 2020-02-14T13:51:38.723Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column waterfall has expected size. - 
[task 2020-02-14T13:51:38.723Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | All visible columns cover 100%. - 
[task 2020-02-14T13:51:38.723Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column status has changed width correctly. - 
[task 2020-02-14T13:51:38.723Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column method has changed width correctly. - 
[task 2020-02-14T13:51:38.724Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column domain has changed width correctly. - 
[task 2020-02-14T13:51:38.724Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column file has changed width correctly. - 
[task 2020-02-14T13:51:38.725Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column cause has changed width correctly. - 
[task 2020-02-14T13:51:38.726Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column initiator has changed width correctly. - 
[task 2020-02-14T13:51:38.726Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column type has changed width correctly. - 
[task 2020-02-14T13:51:38.727Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column transferred has changed width correctly. - 
[task 2020-02-14T13:51:38.727Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column contentSize has changed width correctly. - 
[task 2020-02-14T13:51:38.727Z] 13:51:38     INFO - Checking alignment of columns and headers...
[task 2020-02-14T13:51:38.728Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 0 are aligned. - 
[task 2020-02-14T13:51:38.729Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 1 are aligned. - 
[task 2020-02-14T13:51:38.730Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 2 are aligned. - 
[task 2020-02-14T13:51:38.731Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 3 are aligned. - 
[task 2020-02-14T13:51:38.733Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 4 are aligned. - 
[task 2020-02-14T13:51:38.735Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 5 are aligned. - 
[task 2020-02-14T13:51:38.735Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 6 are aligned. - 
[task 2020-02-14T13:51:38.736Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 7 are aligned. - 
[task 2020-02-14T13:51:38.736Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 8 are aligned. - 
[task 2020-02-14T13:51:38.738Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Headers for columns number 9 are aligned. - 
[task 2020-02-14T13:51:38.738Z] 13:51:38     INFO - Hide all but 2 columns - size & waterfall and check resizing...
[task 2020-02-14T13:51:38.739Z] 13:51:38     INFO - Clicking context-menu item for status
[task 2020-02-14T13:51:38.902Z] 13:51:38     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column status should be hidden - 
[task 2020-02-14T13:51:38.902Z] 13:51:38     INFO - Clicking context-menu item for method
[task 2020-02-14T13:51:39.024Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column method should be hidden - 
[task 2020-02-14T13:51:39.024Z] 13:51:39     INFO - Clicking context-menu item for domain
[task 2020-02-14T13:51:39.142Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column domain should be hidden - 
[task 2020-02-14T13:51:39.142Z] 13:51:39     INFO - Clicking context-menu item for file
[task 2020-02-14T13:51:39.259Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column file should be hidden - 
[task 2020-02-14T13:51:39.260Z] 13:51:39     INFO - Clicking context-menu item for cause
[task 2020-02-14T13:51:39.361Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column cause should be hidden - 
[task 2020-02-14T13:51:39.361Z] 13:51:39     INFO - Clicking context-menu item for type
[task 2020-02-14T13:51:39.462Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column type should be hidden - 
[task 2020-02-14T13:51:39.462Z] 13:51:39     INFO - Clicking context-menu item for transferred
[task 2020-02-14T13:51:39.559Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column transferred should be hidden - 
[task 2020-02-14T13:51:39.616Z] 13:51:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-14T13:51:39.619Z] 13:51:39     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column contentSize has expected size. - Got 10, expected 50
[task 2020-02-14T13:51:39.619Z] 13:51:39     INFO - Stack trace:
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_headers-resize.js:checkColumnsData:203
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_headers-resize.js:null:98
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column waterfall has expected size. - 
[task 2020-02-14T13:51:39.620Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | All visible columns cover 100%. - 
[task 2020-02-14T13:51:39.621Z] 13:51:39     INFO - Hide all but 2 columns - domain & file and check resizing...
[task 2020-02-14T13:51:39.621Z] 13:51:39     INFO - Clicking context-menu item for domain
[task 2020-02-14T13:51:39.722Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column domain should be visible - 
[task 2020-02-14T13:51:39.722Z] 13:51:39     INFO - Clicking context-menu item for file
[task 2020-02-14T13:51:39.825Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column file should be visible - 
[task 2020-02-14T13:51:39.826Z] 13:51:39     INFO - Clicking context-menu item for contentSize
[task 2020-02-14T13:51:39.923Z] 13:51:39     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column contentSize should be hidden - 
[task 2020-02-14T13:51:39.924Z] 13:51:39     INFO - Clicking context-menu item for waterfall
[task 2020-02-14T13:51:40.041Z] 13:51:40     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column waterfall should be hidden - 
[task 2020-02-14T13:51:40.103Z] 13:51:40     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column domain has expected size. - 
[task 2020-02-14T13:51:40.103Z] 13:51:40     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-14T13:51:40.105Z] 13:51:40     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_headers-resize.js | Column file has expected size. - Got 33, expected 50
[task 2020-02-14T13:51:40.105Z] 13:51:40     INFO - Stack trace:
[task 2020-02-14T13:51:40.105Z] 13:51:40     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-02-14T13:51:40.106Z] 13:51:40     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_headers-resize.js:checkColumnsData:203
[task 2020-02-14T13:51:40.106Z] 13:51:40     INFO - chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_headers-resize.js:null:123
[task 2020-02-14T13:51:40.106Z] 13:51:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-14T13:51:40.106Z] 13:51:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-14T13:51:40.107Z] 13:51:40     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-14T13:51:40.107Z] 13:51:40     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:914
[task 2020-02-14T13:51:40.108Z] 13:51:40     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | All visible columns cover 100%. - 
[task 2020-02-14T13:51:40.108Z] 13:51:40     INFO - Destroying the specified network monitor.
[task 2020-02-14T13:51:40.109Z] 13:51:40     INFO - Wait for completion of all NetworkUpdateEvents packets...
[task 2020-02-14T13:51:40.327Z] 13:51:40     INFO - All pending requests finished.
[task 2020-02-14T13:51:41.015Z] 13:51:41     INFO - Removing tab.
[task 2020-02-14T13:51:41.015Z] 13:51:41     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-02-14T13:51:41.071Z] 13:51:41     INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-02-14T13:51:41.120Z] 13:51:41     INFO - Tab removed and finished closing
[task 2020-02-14T13:51:41.124Z] 13:51:41     INFO - Leaving test bound 
[task 2020-02-14T13:51:41.226Z] 13:51:41     INFO - TEST-PASS | devtools/client/netmonitor/test/browser_net_headers-resize.js | The main process DebuggerServer has no pending connection when the test ends - 
[task 2020-02-14T13:51:41.227Z] 13:51:41     INFO - finish() was called, cleaning up...
[task 2020-02-14T13:51:41.251Z] 13:51:41     INFO - GECKO(2708) | MEMORY STAT | vsize 20976128MB | residentFast 2110MB
[task 2020-02-14T13:51:41.252Z] 13:51:41     INFO - TEST-OK | devtools/client/netmonitor/test/browser_net_headers-resize.js | took 6059ms

Flags: needinfo?(bryan.wyern1)

Bryan Kok [:transfusion]

Assignee

Comment 8

•

4 years ago

(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #7)

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288931110&repo=autoland&lineNumber=3444

Apologies - I do not have access to the test server yet so I missed these.
I have updated the diff which fixes both these failures.

browser_net_filter-autocomplete.js tests for the expected list of available columns that can be filtered by simulating "-". The only change I have done here is adding "-initiator:", in alphabetical order since that is now returned in the list.

browser_net_headers-resize.js was failing because I didn't realize that the width property of all the columns in devtools.netmonitor.visibleColumns had to sum to 100. The original distribution of the widths is:

status: 5, method: 5, domain: 10, file: 25, cause: 10, type: 5, transferred: 10, contentSize: 5, waterfall: 25

I thought about taking 10% away from the file column, but that would break the test because it expects the file column to be bigger than 20% [1], so I decided to take 10% away from the waterfall instead. The new distribution is:

status: 5, method: 5, domain: 10, file: 25, cause: 10, type: 5, initiator: 10, transferred: 10, contentSize: 5, waterfall: 15

I have changed this in both head.js for the test harness and the default browser/app/profile/firefox.js.

[1] https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/browser_net_headers-resize.js#45-47

Flags: needinfo?(odvarko)

Flags: needinfo?(hkirschner)

Flags: needinfo?(btara)

Flags: needinfo?(bryan.wyern1)

Bogdan Tara[:bogdan_tara | bogdant]

Updated

•

4 years ago

Flags: needinfo?(btara)

Pulsebot

Comment 9

•

4 years ago

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92266067ef56
Add a column displaying the last frame in the stack trace info if it exists r=Harald,Honza

Cosmin Sabou [:CosminS]

Comment 10

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/92266067ef56

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox75: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 75

:Harald Kirschner :digitarald

Reporter

Updated

•

4 years ago

Blocks: 1617277

:Harald Kirschner :digitarald

Reporter

Updated

•

4 years ago

Blocks: 1618417

:Harald Kirschner :digitarald

Reporter

Comment 11

•

4 years ago

(Clearing nis since this landed – thanks again Bryan)

Flags: needinfo?(odvarko)

Flags: needinfo?(hkirschner)

:Harald Kirschner :digitarald

Reporter

Updated

•

4 years ago

Blocks: 1623110