1592625 - Allocations can be allocated and freed on different threads

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Greg Tatum [:gregtatum]]

Bug 1582741 is going to balance the allocations and frees. However, memory is not restricted to a single thread. We can allocate in one thread, and then deallocate in another. We should probably be smarter about how we approach this.

Possibly we could collect all the markers in a process in the main thread, and not do everything on a per-thread basis. We could potentially include the memory address and thread id in the payloads, then reconstruct what happened on the front end.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1592625 - All threads' allocation markers get stored on the main thread; r?gerald

This change makes it so that all allocations are stored on the main
thread. This way its easy to balance allocations with frees. Memory
happens more in a per-process model, than a per-thread model. The
front-end can then process the information and display it in more
interesting ways.

Depends on D51936

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a685f299700
All threads' allocation markers get stored on the main thread; r=gerald

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out 6 changesets (Bug 1582741, Bug 1593318, Bug 1592625) for causing failures in test_feature_nativeallocations.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=275862534&resultStatus=testfailed%2Cbusted%2Cexception&revision=fb009d42d01204cd1b2eeb55e8d9ddb82c3c4136&searchStr=xpcshell

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275862534&repo=autoland&lineNumber=2904

Backout: https://hg.mozilla.org/integration/autoland/rev/48f393dfe9ac8843956480c554d6160c5e50a7a8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/439f620efb11
All threads' allocation markers get stored on the main thread; r=gerald

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/439f620efb11