Closed Bug 1592625 Opened 1 year ago Closed 1 year ago

Allocations can be allocated and freed on different threads

Categories

(Core :: Gecko Profiler, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1582741 is going to balance the allocations and frees. However, memory is not restricted to a single thread. We can allocate in one thread, and then deallocate in another. We should probably be smarter about how we approach this.

Possibly we could collect all the markers in a process in the main thread, and not do everything on a per-thread basis. We could potentially include the memory address and thread id in the payloads, then reconstruct what happened on the front end.

This change makes it so that all allocations are stored on the main
thread. This way its easy to balance allocations with frees. Memory
happens more in a per-process model, than a per-thread model. The
front-end can then process the information and display it in more
interesting ways.

Depends on D51936

Assignee: nobody → gtatum
Attachment #9106739 - Attachment description: Bug 1592625 - Only collect allocations on the main thread; r?gerald → Bug 1592625 - All threads' allocation markers get stored on the main thread; r?gerald
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a685f299700
All threads' allocation markers get stored on the main thread; r=gerald
Flags: needinfo?(gtatum)
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/439f620efb11
All threads' allocation markers get stored on the main thread; r=gerald
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.