Closed Bug 1593318 Opened 4 months ago Closed 3 months ago

De-duplicate head.js files in profiler tests

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

Details

Attachments

(1 file)

We don't have a shared place where functions can live for both xpcshell tests and for mochitests. We generally use xpcshell tests for testing simpler features, and mochitests for more complicated integrated ones. However, they both need to modify the profiler state in similar ways.

The tests for xpcshell and mochitests were pretty similar, and need to
do similar things. This commit creates a shread-head.js file where those
functions can be shared. This patch also renames a few shared functions
to give them more clarity in their current usage.

Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9714539ae90
De-duplicate head.js files in profiler tests; r=canaltinova
Flags: needinfo?(gtatum)
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9cdc93b402a2
De-duplicate head.js files in profiler tests; r=canaltinova
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.