1593318 - De-duplicate head.js files in profiler tests

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P3)

Description

[Greg Tatum [:gregtatum]]

We don't have a shared place where functions can live for both xpcshell tests and for mochitests. We generally use xpcshell tests for testing simpler features, and mochitests for more complicated integrated ones. However, they both need to modify the profiler state in similar ways.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1593318 - De-duplicate head.js files in profiler tests; r?canaltinova

The tests for xpcshell and mochitests were pretty similar, and need to
do similar things. This commit creates a shread-head.js file where those
functions can be shared. This patch also renames a few shared functions
to give them more clarity in their current usage.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9714539ae90
De-duplicate head.js files in profiler tests; r=canaltinova

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out 6 changesets (Bug 1582741, Bug 1593318, Bug 1592625) for causing failures in test_feature_nativeallocations.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=275862534&resultStatus=testfailed%2Cbusted%2Cexception&revision=fb009d42d01204cd1b2eeb55e8d9ddb82c3c4136&searchStr=xpcshell

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275862534&repo=autoland&lineNumber=2904

Backout: https://hg.mozilla.org/integration/autoland/rev/48f393dfe9ac8843956480c554d6160c5e50a7a8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cdc93b402a2
De-duplicate head.js files in profiler tests; r=canaltinova

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9cdc93b402a2