1592914 - [new popup] Consider using startProfiler from background.jsm.js for all situations

Status: NEW

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

Description

[Julien Wajsberg [:julienw]]

With the current setup I believe we could use startProfiler [1] directly for all situations, including in a remote setup. Obviously for that setup if will be called by the actor.

The popup and devtools panel settings UI job is to change the preferences on the debugging target. Then startProfiler uses these preferences directly on the same running gecko.

Advantages:

• we don't need to pass the options through the devtools protocol
• when/if we move the settings to a separate page, the "start/capture" button could be a super simple app without react

Drawbacks:

• need to manage backward compatibility

[1] https://searchfox.org/mozilla-central/rev/1fe0cf575841dbf3b7e159e88ba03260cd1354c0/devtools/client/performance-new/popup/background.jsm.js#173-194

Any opinion on this Greg ?

Comment 1

[Julien Wajsberg [:julienw]]

using a more direct captureProfile is more challenging given all the retrieving / symbolication mechanism. But because this happens only once the profiler runs, maybe we could accept loading more JS files for this state (?)