Closed Bug 1592996 Opened 4 years ago Closed 4 years ago

Markup view stuck at iframe root when using frame switcher

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox-esr68 unaffected, firefox70 unaffected, firefox71 unaffected, firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 72
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 --- fixed

People

(Reporter: rcaliman, Assigned: jdescottes)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Screen Shot 2019-10-31 at 14.21.58.png
229.67 KB, image/png
Details
Bug 1592996 - Bail out from walker.findNodeFront if the walker cannot reach the selectors
47 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce

Expected

The markup view updates to show the iframe contents.

Actual Result

The markup view stops rendering at the root node.

Mozregression range. Likely regressed by changes in Bug 1590050.

Error in console

TypeError: "container.editor is undefined"
    showNode resource://devtools/client/inspector/markup/markup.js:1577
    process resource://gre/modules/Promise-backend.js:961
    walkerLoop resource://gre/modules/Promise-backend.js:845
    scheduleWalkerLoop resource://gre/modules/Promise-backend.js:775
    schedulePromise resource://gre/modules/Promise-backend.js:809
    completePromise resource://gre/modules/Promise-backend.js:741
    checkForCompletion resource://gre/modules/Promise-backend.js:596
    resolver resource://gre/modules/Promise-backend.js:603
markup.js:425:15
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

Thanks for filing, I will try to fix this.

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04603499b2ea
Bail out from walker.findNodeFront if the walker cannot reach the selectors r=rcaliman

https://hg.mozilla.org/mozilla-central/rev/04603499b2ea

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.