Closed Bug 1593089 Opened 6 years ago Closed 6 years ago

Refactor existing emulation actor into separate emulation-specific actors

Categories

(DevTools :: General, task, P3)

task

Tracking

(firefox74 fixed)

RESOLVED FIXED
Firefox 74
Tracking Status
firefox74 --- fixed

People

(Reporter: mtigley, Assigned: mtigley)

References

Details

Attachments

(1 file)

The emulation actor has several actor methods that allow DevTools to override different browser features to simulate many different environments. Some of these simulations include touch-simulation, viewport orientation, print simulation - just to name a few. However, it's getting to a point where the emulation actor is becoming the place to mix-in different ways to simulate in the browser and can get out of hand in the future.

This bug looks at refactoring the existing emulation actor into separate, functionality-specific emulation actors. As it is right now, the emulation actor is a mix of methods for simulating environments for RDM and content-viewer specific simulations (i.e: print simulation and color scheme simulation, both of which have nothing to do with RDM as it is right now). In theory, we can just move the RDM-specific actor methods into their own actor and move the content-viewer specific methods into another.

Another reason to do this is that the DevTools toolbox and RDM create their own copies of the emulation actor and end up duplicating methods that aren't used by the other. This leads to issues where the RDM-specific emulation actor also tries to clean-up print-simulation environments (see Bug 1543234) when closing.

Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Blocks: 1606852
Pushed by mtigley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/066e940f0da5 Refactor existing emulation actor to ResponsiveEmulation actor and ContentViewerEmulation actor. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Depends on: 1649736
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: