1593329 - Perma [tier2] Assertion failure: cx->isExceptionPending() (Thunk execution failed but no exception was raised - missing call to js::ReportOutOfMemory()?), at /builds/worker/workspace/build/src/js/src/builtin/TestingFunctions.cpp:2196

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: dvarga [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=274136303&repo=mozilla-central
Full log: https://queue.taskcluster.net/v1/task/H_qZyL5zRP6fduHexDaqdA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-11-01T18:53:37.680Z] 18:53:37     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/elements-post-write-barrier.js | Success (code 0, args "--baseline-eager") [0.8 s]
[task 2019-11-01T18:53:38.182Z] 18:53:38     INFO -  [CodeCoverage] Setting handlers for process 24001.
[task 2019-11-01T18:53:38.182Z] 18:53:38     INFO -  Assertion failure: cx->isExceptionPending() (Thunk execution failed but no exception was raised - missing call to js::ReportOutOfMemory()?), at /builds/worker/workspace/build/src/js/src/builtin/TestingFunctions.cpp:2196
[task 2019-11-01T18:53:38.183Z] 18:53:38     INFO -  Exit code: -11
[task 2019-11-01T18:53:38.184Z] 18:53:38     INFO -  FAIL - gc/finalizationGroup.js
[task 2019-11-01T18:53:38.185Z] 18:53:38  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/gc/finalizationGroup.js | [CodeCoverage] Setting handlers for process 24001. (code -11, args "--enable-weak-refs") [0.5 s]
[task 2019-11-01T18:53:38.186Z] 18:53:38     INFO -  INFO exit-status     : -11
[task 2019-11-01T18:53:38.186Z] 18:53:38     INFO -  INFO timed-out       : False
[task 2019-11-01T18:53:38.186Z] 18:53:38     INFO -  INFO stderr         2> [CodeCoverage] Setting handlers for process 24001.
[task 2019-11-01T18:53:38.187Z] 18:53:38     INFO -  INFO stderr         2> Assertion failure: cx->isExceptionPending() (Thunk execution failed but no exception was raised - missing call to js::ReportOutOfMemory()?), at /builds/worker/workspace/build/src/js/src/builtin/TestingFunctions.cpp:2196
[task 2019-11-01T18:53:38.408Z] 18:53:38     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/elements-post-write-barrier.js | Success (code 0, args "--blinterp-eager") [0.8 s]
[task 2019-11-01T18:53:39.277Z] 18:53:39     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/elements-post-write-barrier.js | Success (code 0, args "--no-blinterp --no-baseline --no-ion --more-compartments") [2.0 s]
[task 2019-11-01T18:53:40.470Z] 18:53:40     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/finalizationGroup.js | Success (code 0, args "--enable-weak-refs --ion-eager --ion-offthread-compile=off --more-compartments") [2.3 s]
[task 2019-11-01T18:53:40.668Z] 18:53:40     INFO -  TEST-PASS | tests/jit-test/jit-test/tests/gc/finalizationGroup.js | Success (code 0, args "--enable-weak-refs --ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [2.3 s]
[task 2019-11-01T18:53:40.918Z] 18:53:40     INFO -  [CodeCoverage] Setting handlers for process 24021.
[task 2019-11-01T18:53:40.919Z] 18:53:40     INFO -  Assertion failure: cx->isExceptionPending() (Thunk execution failed but no exception was raised - missing call to js::ReportOutOfMemory()?), at /builds/worker/workspace/build/src/js/src/builtin/TestingFunctions.cpp:2196
[task 2019-11-01T18:53:40.920Z] 18:53:40     INFO -  Exit code: -11
[task 2019-11-01T18:53:40.922Z] 18:53:40     INFO -  FAIL - gc/finalizationGroup.js
[task 2019-11-01T18:53:40.923Z] 18:53:40  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/gc/finalizationGroup.js | [CodeCoverage] Setting handlers for process 24021. (code -11, args "--enable-weak-refs --no-blinterp --no-baseline --no-ion --more-compartments") [0.4 s]
[task 2019-11-01T18:53:40.925Z] 18:53:40     INFO -  INFO exit-status     : -11
[task 2019-11-01T18:53:40.926Z] 18:53:40     INFO -  INFO timed-out       : False
[task 2019-11-01T18:53:40.928Z] 18:53:40     INFO -  INFO stderr         2> [CodeCoverage] Setting handlers for process 24021.
[task 2019-11-01T18:53:40.929Z] 18:53:40     INFO -  INFO stderr         2> Assertion failure: cx->isExceptionPending() (Thunk execution failed but no exception was raised - missing call to js::ReportOutOfMemory()?), at /builds/worker/workspace/build/src/js/src/builtin/TestingFunctions.cpp:2196

Comment 1

[Cristina Coroiu [:ccoroiu]]

Started with this merge:
https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=475496111203207e076e6ac8c62d4dfc87df871f

Could be from this push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ff865fdb64c3a3bfa47e1a554f8c4422aea5d0a1?
https://bugzilla.mozilla.org/show_bug.cgi?id=1587096

Retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Cretry%2Crunnable&searchStr=linux%2Cx64%2Cccov%2Cdebug%2Ctest-linux64-ccov%2Fdebug-jittest-1proc-4%2C%28jit4%29&tochange=475496111203207e076e6ac8c62d4dfc87df871f&fromchange=6fab67ec8c3236848965eec3776a3b628d019124

Jon, can you please take a look at this?

Comment 2

[Intermittent Failures Robot]

21 failures in 4314 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 21

Platform breakdown:

• linux64-ccov: 14
• windows10-64-ccov: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1593329&startday=2019-10-28&endday=2019-11-03&tree=all

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1593329 - Fix problems handling OOM related to FinalizationGroup r?sfink

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1593329 - Make oomTest delazify its thunk first so that allocations doing that don't mask those in the thunk itself r?sfink

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1593329 - Split up FinalizationGroup tests r?sfink

Depends on D52026

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/139cd5e4f7db
Fix problems handling OOM related to FinalizationGroup r=sfink
https://hg.mozilla.org/integration/autoland/rev/382341353d0d
Make oomTest delazify its thunk first so that allocations doing that don't mask those in the thunk itself r=sfink
https://hg.mozilla.org/integration/autoland/rev/6daf24d641d9
Split up FinalizationGroup tests r=sfink

Comment 7

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1593329) for causing spidermonkey bustages in js/src/builtin/FinalizationGroupObject.cpp:229 CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=275284194

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275284194&repo=autoland&lineNumber=8628

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92e49cf89327
Backed out 3 changesets for causing spidermonkey bustages in js/src/builtin/FinalizationGroupObject.cpp:229 CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52be2a1daacd
Fix problems handling OOM related to FinalizationGroup r=sfink
https://hg.mozilla.org/integration/autoland/rev/1de3fc411ada
Make oomTest delazify its thunk first so that allocations doing that don't mask those in the thunk itself r=sfink
https://hg.mozilla.org/integration/autoland/rev/aa8e5bc16edd
Split up FinalizationGroup tests r=sfink

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/52be2a1daacd
https://hg.mozilla.org/mozilla-central/rev/1de3fc411ada
https://hg.mozilla.org/mozilla-central/rev/aa8e5bc16edd

Comment 11

[Intermittent Failures Robot]

51 failures in 4850 pushes (0.011 failures/push) were associated with this bug in the last 7 days.

This is the #35 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 43
• try: 8

Platform breakdown:

• linux64-ccov: 29
• windows10-64-ccov: 22

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1593329&startday=2019-11-04&endday=2019-11-10&tree=all