Closed Bug 1593435 Opened 5 years ago Closed 5 years ago

Perma TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | Missing expected exception. Should get a remote outer window proxy when accessing old window proxy - when Gecko 72 merges to Beta on 2019-12-02

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla72
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 + verified

People

(Reporter: apavel, Assigned: pbone)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 obsolete file)

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=274212104&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=7615639a6ca7cad0078a854e1331d7a58444619a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274212104&repo=try&lineNumber=1894

[task 2019-11-02T11:36:28.939Z] 11:36:28 INFO - TEST-START | dom/tests/browser/browser_windowProxy_transplant.js
[task 2019-11-02T11:36:30.433Z] 11:36:30 INFO - GECKO(1177) | Content running top level script http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-11-02T11:36:30.476Z] 11:36:30 INFO - GECKO(1177) | Content got load of http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-11-02T11:36:30.496Z] 11:36:30 INFO - GECKO(1177) | Content got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"event":"load","location":"http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2019-11-02T11:36:30.653Z] 11:36:30 INFO - GECKO(1177) | Content running top level script http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-11-02T11:36:30.673Z] 11:36:30 INFO - GECKO(1177) | Content got load of http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-11-02T11:36:30.871Z] 11:36:30 INFO - GECKO(1177) | Content got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"event":"load","location":"http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2019-11-02T11:36:30.879Z] 11:36:30 INFO - GECKO(1177) | Content got event http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html {"action":"navigate","location":"http://example.com/browser/dom/tests/browser/file_postMessage_parent.html"}
[task 2019-11-02T11:36:30.935Z] 11:36:30 INFO - GECKO(1177) | Content running top level script http://example.com/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-11-02T11:36:30.951Z] 11:36:30 INFO - GECKO(1177) | Content got load of http://example.com/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-11-02T11:36:30.951Z] 11:36:30 INFO - GECKO(1177) | content.win1 [object Window]
[task 2019-11-02T11:36:30.951Z] 11:36:30 INFO - GECKO(1177) | content.win2 [object Window]
[task 2019-11-02T11:36:30.986Z] 11:36:30 INFO - TEST-INFO | started process screentopng
[task 2019-11-02T11:36:31.489Z] 11:36:31 INFO - TEST-INFO | screentopng: exit 0
[task 2019-11-02T11:36:31.490Z] 11:36:31 INFO - Buffered messages logged at 11:36:28
[task 2019-11-02T11:36:31.492Z] 11:36:31 INFO - Entering test bound
[task 2019-11-02T11:36:31.498Z] 11:36:31 INFO - Buffered messages logged at 11:36:30
[task 2019-11-02T11:36:31.498Z] 11:36:31 INFO - Chrome script has loaded initial URI.
[task 2019-11-02T11:36:31.498Z] 11:36:31 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2019-11-02T11:36:31.498Z] 11:36:31 INFO - Chrome script created iframe
[task 2019-11-02T11:36:31.499Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win0 shouldn't be a dead wrapper before navigation - true == true -
[task 2019-11-02T11:36:31.500Z] 11:36:31 INFO - Got an iframe load event!
[task 2019-11-02T11:36:31.501Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | waiving xrays creates a new thing? - true == true -
[task 2019-11-02T11:36:31.502Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to same-origin BrowsingContext match - {} == {} -
[task 2019-11-02T11:36:31.504Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | same to same-origin WindowProxy match - [object Window] == [object Window] -
[task 2019-11-02T11:36:31.506Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win1 shouldn't be a dead wrapper before navigation - true == true -
[task 2019-11-02T11:36:31.507Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1 shouldn't be a dead wrapper before navigation - true == true -
[task 2019-11-02T11:36:31.508Z] 11:36:31 INFO - Chrome script asking for load of http://example.com/browser/dom/tests/browser/file_postMessage_parent.html
[task 2019-11-02T11:36:31.509Z] 11:36:31 INFO - Chrome script done calling PostMessage
[task 2019-11-02T11:36:31.512Z] 11:36:31 INFO - Console message: [JavaScript Warning: "window.controllers/Controllers is deprecated. Do not use it for UA detection." {file: "http://mochi.test:8888/browser/dom/tests/browser/file_postMessage_parent.html" line: 0}]
[task 2019-11-02T11:36:31.513Z] 11:36:31 INFO - Got an iframe load event!
[task 2019-11-02T11:36:31.514Z] 11:36:31 INFO - Buffered messages finished
[task 2019-11-02T11:36:31.515Z] 11:36:31 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | Missing expected exception. Should get a remote outer window proxy when accessing old window proxy -
[task 2019-11-02T11:36:31.515Z] 11:36:31 INFO - Stack trace:
[task 2019-11-02T11:36:31.517Z] 11:36:31 INFO - resource://testing-common/content-task.js line 110 > eval:null:89
[task 2019-11-02T11:36:31.518Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | . Should get a remote outer window proxy when accessing old window proxy -
[task 2019-11-02T11:36:31.519Z] 11:36:31 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-02T11:36:31.520Z] 11:36:31 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | Missing expected exception. Should get a remote outer window proxy when accessing new window proxy -
[task 2019-11-02T11:36:31.520Z] 11:36:31 INFO - Stack trace:
[task 2019-11-02T11:36:31.521Z] 11:36:31 INFO - resource://testing-common/content-task.js line 110 > eval:null:96
[task 2019-11-02T11:36:31.521Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | . Should get a remote outer window proxy when accessing new window proxy -
[task 2019-11-02T11:36:31.522Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | win1 shouldn't be a dead wrapper after navigation - true == true -
[task 2019-11-02T11:36:31.523Z] 11:36:31 INFO - TEST-PASS | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1 shouldn't be a dead wrapper after navigation - true == true -
[task 2019-11-02T11:36:31.523Z] 11:36:31 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-02T11:36:31.524Z] 11:36:31 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | chromeWin1x should be a dead wrapper after navigation - false == true -
[task 2019-11-02T11:36:31.525Z] 11:36:31 INFO - Stack trace:
[task 2019-11-02T11:36:31.526Z] 11:36:31 INFO - resource://testing-common/content-task.js line 110 > eval:null:116
[task 2019-11-02T11:36:31.527Z] 11:36:31 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-02T11:36:31.528Z] 11:36:31 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | content.win1x should be a dead wrapper after navigation - false == true -

Hi André , can this be from bug 1526870?

Flags: needinfo?(andrebargull)

Assuming this is from bug 1562667 (there is also bug 1591212 but that doesn't have an obvious dependency on a channel).

Flags: needinfo?(andrebargull) → needinfo?(ttung)
Regressed by: 1562667
No longer regressed by: 1526870

I don't think it's related to bug 1562667 because that the change inside is protected by a pref and the pref is default off in all channels. Also, the change inside is related to both postMessage or SharedArrayBuffer. In this test, the pref is off (isn't modified in the test) and I cannot find it new a SharedArrayBuffer. So at this moment, I don't think it's related to bug 1562667.

From the error message:

[task 2019-11-02T11:36:31.520Z] 11:36:31 INFO - TEST-UNEXPECTED-FAIL | dom/tests/browser/browser_windowProxy_transplant.js | Missing expected exception. Should get a remote outer window proxy when accessing new window proxy -

It looks like it got a wrong window proxy, but I don't know which bug might related to or who I should ask for. So redirect the ni back.

Flags: needinfo?(ttung) → needinfo?(aryx.bugmail)
No longer regressed by: 1562667

This looks like a dup of bug 1569550?

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Per comment 5, ni :stetar for more information.

Flags: needinfo?(sdetar)

Neha or Hsin-Yi, do you who else could look at this while Paul is on PTO this week?

Flags: needinfo?(sdetar)
Flags: needinfo?(nkochar)
Flags: needinfo?(htsai)

Andrew, can you look into this, while pbone is on PTO this week?

Flags: needinfo?(nkochar)
Flags: needinfo?(htsai)
Flags: needinfo?(continuation)

This is a regression from a document channel change, so I think it would make more sense for Matt to look at it.

The test that is failing is attempting to call Symbol.toPrimitive on a cross-origin window, and checks that it throws the correct exception. If it turns out to be some question of wrapper behavior, I can take a look at that. But I think the first question is why this patch caused a change in behavior at all here.

Flags: needinfo?(continuation) → needinfo?(matt.woodrow)

DocumentChannel is currently restricted to Nightly only, and this test is flipping browser.tabs.remote.useHTTPResponseProcessSelection=true (which as of bug 1588412 depends on DocumentChannel).

We can either let DocumentChannel ride the trains, or just add the DocumentChannel pref (browser.tabs.documentchannel=true) to this test.

Is this urgent? Adding ni?pbone for him to fix next week.

Flags: needinfo?(matt.woodrow) → needinfo?(pbone)
See Also: → 1593447

Whether or not we let DocumentChannel ride the trains I'm going to have this test enable DocumentChannel.

Bug 1592894 will be removing browser.tabs.remote.useHTTPResponseProcessSelection in favour of documentchannel. We might as well flip both in this test until Bug 1592894 lands.

Assignee: nobody → pbone
Blocks: 1592894
Status: NEW → ASSIGNED
Flags: needinfo?(pbone)
See Also: → 1593437

Fixed in bug 1595284.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Attachment #9107771 - Attachment is obsolete: true
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: