1593533 - getAllWindowDebuggees should be robust against exceptions

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Brian Hackett [Laid off!]]

I'm running into an issue landing bug 1583546 where if the debugger pauses early enough, it breaks when pausing due to an exception thrown inside getAllWindowDebuggees:

[task 2019-11-03T14:24:46.121Z] 14:24:46     INFO - GECKO(1656) | TA__pauseAndRespond threw an exception: [Exception... "Component not initialized"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://devtools/server/actors/utils/event-loop.js :: getAllWindowDebuggees/< :: line 135"  data: no]
[task 2019-11-03T14:24:46.121Z] 14:24:46     INFO - GECKO(1656) | Stack: getAllWindowDebuggees/<@resource://devtools/server/actors/utils/event-loop.js:135:31
[task 2019-11-03T14:24:46.126Z] 14:24:46     INFO - GECKO(1656) | getAllWindowDebuggees@resource://devtools/server/actors/utils/event-loop.js:135:10
[task 2019-11-03T14:24:46.126Z] 14:24:46     INFO - GECKO(1656) | preNest@resource://devtools/server/actors/utils/event-loop.js:145:31
[task 2019-11-03T14:24:46.126Z] 14:24:46     INFO - GECKO(1656) | enter@resource://devtools/server/actors/utils/event-loop.js:76:30
[task 2019-11-03T14:24:46.126Z] 14:24:46     INFO - GECKO(1656) | _pushThreadPause@resource://devtools/server/actors/thread.js:250:15
[task 2019-11-03T14:24:46.126Z] 14:24:46     INFO - GECKO(1656) | _pauseAndRespond@resource://devtools/server/actors/thread.js:842:12
[task 2019-11-03T14:24:46.126Z] 14:24:46     INFO - GECKO(1656) | onDebuggerStatement@resource://devtools/server/actors/thread.js:1866:17

I had to fix another issue due to an exception being thrown here a couple months ago, in bug 1577881, which also broke the debugger. I think we should catch all exceptions here and ensure the debugger is able to continue operating.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1593533 - Catch all exceptions thrown when testing if a window is top level, r=ochameau.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf5e611e9d21
Catch all exceptions thrown when testing if a window is top level, r=ochameau.

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cf5e611e9d21