1593560 - Enable DocumentChannel for data URIs

Status: RESOLVED FIXED

(Core :: Networking, task)

Description

[Matt Woodrow (:mattwoodrow)]

Currently DocumentChannel is only enabled for http(s), but we want to add support for other protocols. This bug will add support for data:.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1593560 - Allow data urls with DocumentChannel. r?nika

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1593560 - Adjust tests to wait for data uri to load properly, since it now includes an extra IPDL roundtrip. r?kmag,ochameau

Depends on D51547

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1593560 - Only return false from NS_InputStreamIsBuffered if the underlying object doesn't implement ReadSegments. r?mayhemer

This stops us from returning true on an empty data URI (data:text/html,), since that returns NS_BASE_STREAM_CLOSED.

Depends on D51548

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1593560 - Support non-http channels in SendCrossProcessRedirect. r?jya

Depends on D51549

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1593560 - Release mListener and break the cycle if AsyncOpen fails in DocumentChannelParent, since OnStopRequest won't be delivered to mListener in this case, which is where we usually break the cycle. r?jya

Depends on D51550

Comment 6

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1593560 - Make sure IPCBlobInputStream::ReadSegments is always supported, regardless of which inner async stream type gets created. r?smaug

When ReadSegments is called before the stream is ready, we return NS_BASE_STREAM_WOULD_BLOCK, not NS_ERROR_NOT_IMPLEMENTED.
If callers use AsyncWait for the IPCBlobInputStream to be ready, and then call ReadSegments again we can end up returning NS_ERROR_NOT_IMPLEMENTED, depending on what the inner type is.

Depends on D51552

Comment 7

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1593560 - Fix browser_firstPartyIsolation to not use w.content. r?kmag

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90572c49d464
Allow data urls with DocumentChannel. r=nika
https://hg.mozilla.org/integration/autoland/rev/9f52c9f6dc54
Adjust tests to wait for data uri to load properly, since it now includes an extra IPDL roundtrip. r=kmag,ochameau
https://hg.mozilla.org/integration/autoland/rev/a7d04e276b44
Only return false from NS_InputStreamIsBuffered if the underlying object doesn't implement ReadSegments. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/3e3948e9531c
Support non-http channels in SendCrossProcessRedirect. r=jya
https://hg.mozilla.org/integration/autoland/rev/d67a10437af7
Release mListener and break the cycle if AsyncOpen fails in DocumentChannelParent, since OnStopRequest won't be delivered to mListener in this case, which is where we usually break the cycle. r=jya
https://hg.mozilla.org/integration/autoland/rev/9842c80c98d8
Make sure IPCBlobInputStream::ReadSegments is always supported, regardless of which inner async stream type gets created. r=baku

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dfae085a4cb
Fix browser_firstPartyIsolation to not use w.content. r=kmag

Comment 10

[Cristina Coroiu [:ccoroiu]]

Backed out 7 changesets (bug 1593560) for crashtest failures at tests/layout/base/crashtests/446328.html

Backout: https://hg.mozilla.org/integration/autoland/rev/ffed8d3b4ac5ed66ec2632275f24234b796acdf6

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9842c80c98d83e83c8313f9152359106b4758fc5

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274914437&repo=autoland&lineNumber=28909

Docshell in assertion: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274914437&repo=autoland&lineNumber=28846

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd4e2201c286
Allow data urls with DocumentChannel. r=nika
https://hg.mozilla.org/integration/autoland/rev/ec368ed71cb6
Adjust tests to wait for data uri to load properly, since it now includes an extra IPDL roundtrip. r=kmag,ochameau
https://hg.mozilla.org/integration/autoland/rev/40c8c2cd4fe9
Only return false from NS_InputStreamIsBuffered if the underlying object doesn't implement ReadSegments. r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/7fda1001834a
Support non-http channels in SendCrossProcessRedirect. r=jya
https://hg.mozilla.org/integration/autoland/rev/f85931cd9c30
Release mListener and break the cycle if AsyncOpen fails in DocumentChannelParent, since OnStopRequest won't be delivered to mListener in this case, which is where we usually break the cycle. r=jya
https://hg.mozilla.org/integration/autoland/rev/f370f4b602e0
Make sure IPCBlobInputStream::ReadSegments is always supported, regardless of which inner async stream type gets created. r=baku
https://hg.mozilla.org/integration/autoland/rev/50b6f4d2e0d2
Fix browser_firstPartyIsolation to not use w.content. r=kmag

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bd4e2201c286
https://hg.mozilla.org/mozilla-central/rev/ec368ed71cb6
https://hg.mozilla.org/mozilla-central/rev/40c8c2cd4fe9
https://hg.mozilla.org/mozilla-central/rev/7fda1001834a
https://hg.mozilla.org/mozilla-central/rev/f85931cd9c30
https://hg.mozilla.org/mozilla-central/rev/f370f4b602e0
https://hg.mozilla.org/mozilla-central/rev/50b6f4d2e0d2

Comment 13

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732