1593652 - The "Extended Triplets" are not displayed on the first opened tab on latest Firefox Beta

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Tracking Requested - why for this release]:

• This regression affects the "Extended Triplets" feature and the cards will not be displayed on the first opened tab.

[Affected versions]:

• Firefox Beta 71.0b6 - Build ID: 20191031113544

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a new Firefox profile.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and observe the top part of the page.

[Expected result]:

• The "Extended Triplets" are displayed in the top right part of the page.

[Actual result]:

• The "Extended Triplets" are not displayed at all.

[Regression Window]:

• Considering the fact that this issue is not reproducible on older Firefox builds, using the mozregression tool I have managed to find the following regression window:
  Last good revision: f9a4c8d67be3cbd983306cd90af9737a04cd50f1
  First bad revision: c142790318c4d8bfceebf2e828f950cb7a7412bb
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f9a4c8d67be3cbd983306cd90af9737a04cd50f1&tochange=c142790318c4d8bfceebf2e828f950cb7a7412bb

From the pushlog, it seems that bug 1590504 has caused this issue.

[Notes]:

• The "Extended Triplets" are successfully displayed on the second opened tab.
• The "Extended Triplets" are not displayed at all on the latest Firefox Nightly (72.0a1), but we will treat this behavior in a separate issue.
• Attached a screen recording of the issue.

@Punam, could you please take a look over this issue?

Comment 1

[Punam Dahiya [:pdahiya]]

Thanks @mcoman for catching it. Underlying issue is trailHeadTriplet state doesn't get set for the first opened new tab which was an existing issue but got surfaced with emptying of trailhead.firstrun.branches pref. Fix of this issue should resolve 1593655.

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1593652 - Set default triplet to fix extended triplet on first opened new tab

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1593652 - Set default triplet to fix extended triplet on first opened new tab

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1981ad092389
Set default triplet to fix extended triplet on first opened new tab r=Mardak

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1981ad092389

Comment 7

[Ed Lee :Mardak]

This bug fix is independent of bug 1594125 and is not needed for 70 release uplift.

Comment 9

[Punam Dahiya [:pdahiya]]

Requesting QA to verify this fix in nightly before requesting beta uplift

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (72.0a1 Build ID - 20191110095330) installed, on Windows 10 x64, Arch Linux and Mac 10.15.1. Now, the "Extended Triplets" are successfully displayed on the first opened tab.

Comment 11

[Punam Dahiya [:pdahiya]]

Comment on attachment 9106362 [details]
Bug 1593652 - Set default triplet to fix extended triplet on first opened new tab

Beta/Release Uplift Approval Request

• User impact if declined: Extended triplets will not be seen on the first opened new tab
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1593652#c0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small changes setting default triplets value and updating holdback extended triplets experiment ratio so that we show extended triplets to all users
• String changes made/needed: None

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9106362 [details]
Bug 1593652 - Set default triplet to fix extended triplet on first opened new tab

Fix has tests and is verified on Nightly, uplift approved for 71 beta 10, thanks.

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d385c34efc50

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (71.0b10 Build ID - 20191114160003) installed, on Windows 10 x64, Arch Linux and Mac 10.15.1. Now, the "Extended Triplets" are successfully displayed on the first opened tab.