Closed Bug 1593959 Opened 5 years ago Closed 5 years ago

Introduce a visual gap between results

Categories

(Firefox :: Address Bar, task, P2)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 72
Iteration:
72.2 - Nov 4 - 17
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mak, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Bug 1593959 - Introduce a visual gap between results. r?mak
47 bytes, text/x-phabricator-request
Details | Review

According to the spec, there should be a visual 6px empty gap between 30px tall rows.
We have a few concerns regarding the mousehover state of rows, because it may flicker too much when moving across rows with the gap in the middle.
So this is pending a discussion with UX.

The gap is to be considered a padding, so that mousehover on the gap will still style the result as hovered (but the selected and hovered states are not full height).

Keywords: blocked-ux
Priority: P3 → P2
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 72.2 - Nov 4 - 17

Verdi was thinking to make an interactive mockup for this, so once we have a patch, before landing, we could make a try build and ask him to try if it's what he had in mind.

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ee2e15986b6
Introduce a visual gap between results. r=mak

https://hg.mozilla.org/mozilla-central/rev/4ee2e15986b6

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Regressions: 1596357
Depends on: 1596357
No longer regressions: 1596357
Regressions: 1597077
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: