1594004 - Enable Top-Level Origin Based HTTP-Cache Splitting in Nightly72

Reporter

Description

•

5 years ago

We shipped the code to partition the HTTP cache per the top-level document's origin in 70, behind a flag. We should move forward here and try to turn this on by default in nightly and see what the results are.

Sebastian Streich [:sstreich]

Reporter

Updated

•

5 years ago

Assignee: nobody → sstreich

Sebastian Streich [:sstreich]

Reporter

Comment 1

•

5 years ago

Attached file Bug 1594004 - Enable CacheSplit in nightly r=ckerschb (obsolete) — Details

Junior [inactive]

Updated

•

5 years ago

Priority: -- → P2

Whiteboard: [necko-triaged]

Phabricator Automation

Updated

•

5 years ago

Attachment #9106522 - Attachment description: Bug 1594004 - Enable CacheSplit on default r=ckerschb → Bug 1594004 - Enable CacheSplit on nightly r=ckerschb

Anne (:annevk)

Updated

•

5 years ago

Keywords: dev-doc-needed

Pulsebot

Comment 2

•

5 years ago

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09a0252278f8
Enable CacheSplit on nightly  r=ckerschb,annevk

Cristian Brindusan [:cbrindusan]

Comment 3

•

5 years ago

Backed out changeset 09a0252278f8 (Bug 1594004) for bc failures at browser_about_cache.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/5b224b8fe0140093a967e223c2539b3e7669ecff

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=09a0252278f8bcd493345f2e05179f78f16e5a10&selectedJob=276014523

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276014523&repo=autoland&lineNumber=9081

Flags: needinfo?(sstreich)

Cristian Brindusan [:cbrindusan]

Comment 4

•

5 years ago

There are also wpt failures: https://treeherder.mozilla.org/logviewer.html#?job_id=276014631&repo=autoland

Narcis Beleuzu [:NarcisB]

Comment 5

•

5 years ago

There were also xpcshell failures on test_bug482601.js
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276023806&repo=autoland&lineNumber=1870

Phabricator Automation

Updated

•

5 years ago

Attachment #9106522 - Attachment description: Bug 1594004 - Enable CacheSplit on nightly r=ckerschb → Bug 1594004 - Enable CacheSplit on default r=ckerschb

Pulsebot

Comment 6

•

5 years ago

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e8755b2ddce
Enable CacheSplit on default r=ckerschb,annevk

Andreea Pavel [:apavel]

Comment 7

•

5 years ago

Backed out for failing xpcshell at test_http2.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=277113476&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-linux64%2Fdebug-xpcshell-e10s-3%2Cx%28x3%29&revision=7e8755b2ddce02d2799d36793dd43bd7205e53e6

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277113476&repo=autoland&lineNumber=2516

Backout: https://hg.mozilla.org/integration/autoland/rev/e87f5c17aa873c10d9cbcb42698073c501a72925

Anne (:annevk)

Comment 8

•

5 years ago

I think we should file a follow-up on adjusting the tests to remove the need for the flag flipping. It'd be unfortunate if we could never remove this flag from the code I think.

(no longer active)

Comment 9

•

5 years ago

(In reply to Anne (:annevk) from comment #8)

I think we should file a follow-up on adjusting the tests to remove the need for the flag flipping. It'd be unfortunate if we could never remove this flag from the code I think.

Agreed!

Valentin Gosu [:valentin] (he/him)

Updated

•

5 years ago

Regressions: 1596271

Phabricator Automation

Updated

•

5 years ago

Attachment #9106522 - Attachment description: Bug 1594004 - Enable CacheSplit on default r=ckerschb → Bug 1594004 - Enable CacheSplit in nightly r=ckerschb

Sebastian Streich [:sstreich]

Reporter

Updated

•

5 years ago

Blocks: 1599469

Sebastian Streich [:sstreich]

Reporter

Comment 10

•

5 years ago

I think i catched all the failing tests. I filed Bug 1599469 with all the tests i had to touch :)

No longer blocks: 1599469

Flags: needinfo?(sstreich)

Pulsebot

Comment 11

•

5 years ago

Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c50773d59a2
Enable CacheSplit in nightly  r=ckerschb,annevk

Daniel Varga [:dvarga]

Comment 12

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/4c50773d59a2

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox72: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla72

Pulsebot

Comment 13

•

5 years ago

Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/056ea65222b5
Backed out changeset 4c50773d59a2 for mochitest failures on test_postMessage_solidus.html . CLOSED TREE

Andreea Pavel [:apavel]

Comment 14

•

5 years ago

This got backed out for causing bug 1599516.

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=278313441&repo=autoland&lineNumber=38661

[task 2019-11-26T23:05:02.793Z] 23:05:02 [task 2019-11-26T23:05:02.793Z] 23:05:02 [task 2019-11-26T23:05:02.793Z] 23:05:02 [task 2019-11-26T23:05:02.793Z] 23:05:02 [task 2019-11-26T23:05:02.793Z] 23:05:02 [task 2019-11-26T23:05:02.793Z] 23:05:02 [task 2019-11-26T23:05:02.794Z] 23:05:02 [task 2019-11-26T23:05:02.794Z] 23:05:02 [task 2019-11-26T23:05:02.794Z] 23:05:02 [task 2019-11-26T23:05:02.794Z] 23:05:02 [task 2019-11-26T23:05:02.794Z] 23:05:02 [task 2019-11-26T23:05:02.797Z] 23:05:02 [task 2019-11-26T23:05:02.797Z] 23:05:02 [task 2019-11-26T23:05:02.797Z] 23:05:02 [task 2019-11-26T23:05:02.798Z] 23:05:02 [task 2019-11-26T23:05:02.798Z] 23:05:02 [task 2019-11-26T23:05:02.798Z] 23:05:02 [task 2019-11-26T23:05:02.798Z] 23:05:02 [task 2019-11-26T23:05:02.798Z] 23:05:02 [task 2019-11-26T23:05:02.798Z] 23:05:02 [task 2019-11-26T23:05:02.972Z] 23:05:02 [task 2019-11-26T23:05:02.973Z] 23:05:02 [task 2019-11-26T23:05:03.061Z] 23:05:03 [task 2019-11-26T23:05:03.243Z] 23:05:03 [task 2019-11-26T23:05:03.243Z] 23:05:03 [task 2019-11-26T23:05:03.243Z] 23:05:03 INFO - TEST-START | dom/base/test/test_postMessage_solidus.html
INFO - GECKO(1933) | --DOCSHELL 0x11b325000 == 3 [pid = 1935] [id = {a82c8215-dce1-d74f-a4e7-784eb27c30d5}] [url = http://mochi.test:8888/tests/dom/base/test/file_receiveMessage.html]
INFO - GECKO(1933) | --DOMWINDOW == 24 (0x11dc9ac00) [pid = 1935] [serial = 2368] [outer = 0x0] [url = about:blank]
INFO - GECKO(1933) | --DOMWINDOW == 23 (0x11a3b9800) [pid = 1935] [serial = 2380] [outer = 0x0] [url = about:blank]
INFO - GECKO(1933) | --DOMWINDOW == 22 (0x11d103000) [pid = 1935] [serial = 2365] [outer = 0x0] [url = http://mochi.test:8888/tests/dom/base/test/test_open_null_features.html]
INFO - GECKO(1933) | --DOMWINDOW == 21 (0x11dc90000) [pid = 1935] [serial = 2371] [outer = 0x0] [url = about:blank]
INFO - GECKO(1933) | --DOMWINDOW == 20 (0x11dc08800) [pid = 1935] [serial = 2373] [outer = 0x0] [url = http://mochi.test:8888/tests/dom/base/test/test_pluginAudioNotification.html]
INFO - GECKO(1933) | --DOMWINDOW == 19 (0x145b3fc00) [pid = 1935] [serial = 2377] [outer = 0x0] [url = http://mochi.test:8888/tests/SimpleTest/iframe-between-tests.html]
INFO - GECKO(1933) | [Parent 1933, Main Thread] WARNING: we only accept nsIURI interface type, patch welcome: file /builds/worker/workspace/build/src/dom/ipc/PropertyBagUtils.cpp, line 112
INFO - GECKO(1933) | --DOMWINDOW == 18 (0x1457b1c00) [pid = 1935] [serial = 2376] [outer = 0x0] [url = http://mochi.test:8888/tests/dom/base/test/file_pluginAudio.html]
INFO - GECKO(1933) | --DOMWINDOW == 17 (0x11b383800) [pid = 1935] [serial = 2372] [outer = 0x0] [url = http://mochi.test:8888/tests/SimpleTest/iframe-between-tests.html]
INFO - GECKO(1933) | --DOMWINDOW == 16 (0x11dc92400) [pid = 1935] [serial = 2375] [outer = 0x0] [url = about:blank]
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: '!outputStream', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 2399
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 8450
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 8312
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 8222
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: '!outputStream', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 2399
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 8450
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 8312
INFO - GECKO(1933) | [Parent 1933, QuotaManager IO] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/quota/ActorsParent.cpp, line 8222
INFO - GECKO(1933) | [Child 1935, Main Thread] WARNING: Wrong inner/outer window combination!: file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 6824
INFO - GECKO(1933) | [Child 1935, Main Thread] WARNING: Wrong inner/outer window combination!: file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 6824
INFO - GECKO(1933) | --DOMWINDOW == 15 (0x11a362e20) [pid = 1935] [serial = 2379] [outer = 0x0] [url = http://mochi.test:8888/tests/dom/base/test/file_pluginAudioNonAutoStart.html]
INFO - JavaScript error: /Users/cltbld/tasks/task_1574808572/build/tests/bin/components/httpd.js, line 3824: NS_ERROR_NOT_AVAILABLE:
INFO - JavaScript error: /Users/cltbld/tasks/task_1574808572/build/tests/bin/components/httpd.js, line 3824: NS_ERROR_NOT_AVAILABLE:
INFO - JavaScript error: /Users/cltbld/tasks/task_1574808572/build/tests/bin/components/httpd.js, line 3824: NS_ERROR_NOT_AVAILABLE:

[task 2019-11-26T23:11:42.167Z] 23:11:42 INFO - JavaScript error: /Users/cltbld/tasks/task_1574808572/build/tests/bin/components/httpd.js, line 3824: NS_ERROR_NOT_AVAILABLE:
[task 2019-11-26T23:11:42.186Z] 23:11:42 INFO - JavaScript error: /Users/cltbld/tasks/task_1574808572/build/tests/bin/components/httpd.js, line 3824: NS_ERROR_NOT_AVAILABLE:
[task 2019-11-26T23:11:42.186Z] 23:11:42 INFO - JavaScript error: /Users/cltbld/tasks/task_1574808572/build/tests/bin/components/httpd.js, line 3824: NS_ERROR_NOT_AVAILABLE:
[task 2019-11-26T23:11:42.245Z] 23:11:42 INFO - Buffered messages finished
[task 2019-11-26T23:11:42.245Z] 23:11:42 ERROR - TEST-UNEXPECTED-TIMEOUT | dom/base/test/test_postMessage_solidus.html | application timed out after 370 seconds with no output
[task 2019-11-26T23:11:42.245Z] 23:11:42 ERROR - Force-terminating active process(es).
[task 2019-11-26T23:11:42.245Z] 23:11:42 INFO - Determining child pids from psutil...
[task 2019-11-26T23:11:42.245Z] 23:11:42 INFO - [1934, 1935, 1958, 1959]
[task 2019-11-26T23:11:42.245Z] 23:11:42 INFO - ==> process 1933 launched child process 1934
[task 2019-11-26T23:11:42.245Z] 23:11:42 INFO - ==> process 1933 launched child process 1935
[task 2019-11-26T23:11:42.245Z] 23:11:42 INFO - ==> process 1933 launched child process 1958
[task 2019-11-26T23:11:42.246Z] 23:11:42 INFO - ==> process 1933 launched child process 1959
[task 2019-11-26T23:11:42.246Z] 23:11:42 INFO - ==> process 1933 launched child process 2008
[task 2019-11-26T23:11:42.246Z] 23:11:42 INFO - Found child pids: set([2008, 1959, 1958, 1934, 1935])
[task 2019-11-26T23:11:42.246Z] 23:11:42 INFO - Failed to get child procs
[task 2019-11-26T23:11:42.246Z] 23:11:42 INFO - Killing process: 2008

Status: RESOLVED → REOPENED

status-firefox72: fixed → ---

Flags: needinfo?(sstreich)

Resolution: FIXED → ---

Target Milestone: mozilla72 → ---

BugBot [:suhaib / :marco/ :calixte]

Comment 15

•

4 years ago

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sstreich, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(sstreich)

Phabricator Automation

Updated

•

4 years ago

Attachment #9106522 - Attachment is obsolete: true

Sebastian Streich [:sstreich]

Reporter

Comment 16

•

4 years ago

Clearing ni? and removing myself as i probably dont have time to work on the patch. - Turning cache_splitting on perma fails test_postMessage_solidus.html and similar patches.

Assignee: sstreich → nobody

Flags: needinfo?(sstreich)

Andrea Marchesini [:baku]

Updated

•

4 years ago

Status: REOPENED → RESOLVED

Closed: 5 years ago → 4 years ago

Resolution: --- → DUPLICATE