Closed Bug 1594069 Opened 1 year ago Closed 1 year ago

wptrunner.py:start does not set return value for list* command arguments

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: bc, Assigned: bc)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached patch patchSplinter Review

Running

 ./mach web-platform-tests  --list-tests
 ./mach web-platform-tests  --list-test-groups
 ./mach web-platform-tests  --list-disabled

results in

TypeError: int() argument must be a string or a number, not 'NoneType'

  File "mozilla/builds/autoland/mozilla/testing/web-platform/mach_commands.py", line 301, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "mozilla/builds/autoland/mozilla/testing/web-platform/mach_commands_base.py", line 42, in run
    return int(result)

start() does not return an int or boolean value for the --list* arguments.

The attached patch fixes it for me. I'll defer as to the actual patch.

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/autoland/rev/0b0779e6ebe3
ensure wptrunner.py start() always returns a value, r=jgraham
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20218 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.