1594069 - wptrunner.py:start does not set return value for list* command arguments

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: patch

Running

 ./mach web-platform-tests  --list-tests
 ./mach web-platform-tests  --list-test-groups
 ./mach web-platform-tests  --list-disabled

results in

TypeError: int() argument must be a string or a number, not 'NoneType'

  File "mozilla/builds/autoland/mozilla/testing/web-platform/mach_commands.py", line 301, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "mozilla/builds/autoland/mozilla/testing/web-platform/mach_commands_base.py", line 42, in run
    return int(result)

start() does not return an int or boolean value for the --list* arguments.

The attached patch fixes it for me. I'll defer as to the actual patch.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: Bug 1594069 - ensure wptrunner.py start() always returns a value, r=jgraham

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b0779e6ebe3
ensure wptrunner.py start() always returns a value, r=jgraham

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20218 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/0b0779e6ebe3

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot