1594284 - Fix usage of nsIDocShellTreeItem in nsDocShell::CanAccessItem

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Kannan Vijayan [:djvj]]

https://searchfox.org/mozilla-central/rev/8b7aa8af652f87d39349067a5bc9c0256bf6dedc/docshell/base/nsDocShell.cpp#2881

Caller needs to be changed to passing BrowsingContext* instead, and this method can be simplified greatly.

The actual cleanup here is to nsDocShell::FindChildWithName, which should use BrowsingContext* to iterate over the tree.

Comment 1

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1594284 - Remove nsDocShell::CanAccessItem. r?annyG

Apparently Bug 1594288 removed the user of this function.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/551bc504b93e
Remove nsDocShell::CanAccessItem. r=annyG

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/551bc504b93e