Closed Bug 1594306 Opened 4 years ago Closed 4 years ago

rename nsGeo* files so they match the WebIDL interfaces

Categories

(Core :: DOM: Geolocation, task, P2)

Product:
Core
Component:
DOM: Geolocation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: sidvishnoi, Assigned: sidvishnoi, Mentored)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1594306 - Rename nsGeo* files to match the WebIDL interfaces
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

Summary: Bug 1575144 - update Geolocation implementation to match latest spec → Bug 1575144 - rename nsGeo* files so they match the WebIDL interfaces

This is a followup from review of https://bugzilla.mozilla.org/show_bug.cgi?id=1575144

  • Rename nsGeo* files (and their code) so they match the WebIDL interfaces
  • Fix the outdated comments that reference old interface names
Summary: Bug 1575144 - rename nsGeo* files so they match the WebIDL interfaces → Bug 1575144 - update Geolocation implementation to match latest spec
Mentor: mcaceres
Type: defect → task
Priority: -- → P2
Summary: Bug 1575144 - update Geolocation implementation to match latest spec → rename nsGeo* files so they match the WebIDL interfaces
Assignee: nobody → sidvishnoi8

Rename nsGeolocation to Geolocation.
Split nsGeoPostion to GeolocationPosition and GeolocationCoordinates.
Fix some include guards and comments referencing outdated interfaces.

Rename nsGeolocation to Geolocation.
Split nsGeoPostion to GeolocationPosition and GeolocationCoordinates.
Fix some include guards and comments referencing outdated interfaces.

Attachment #9107779 - Attachment is obsolete: true
Pushed by mcaceres@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9acbf3949ad7
Rename nsGeo* files to match the WebIDL interfaces r=marcosc
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20246 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/9acbf3949ad7

Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.