1594330 - Task-cluster jobs fail when generating raptor gecko-profile tasks

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Florin Strugariu [:Bebe]]

As you can see here:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2Cx64%2Cshippable%2Copt%2Craptor%2Cperformance%2Ctests%2Con%2Cfirefox%2Ctest-linux64-shippable%2Fopt-raptor-tp6-24-firefox-cold-e10s%2Crap%28tp6-c-24-p%29&tochange=af790c1efe5d6e0ee45fad4c02f247467f11db0e&fromchange=f335193ba437543cb8065285f393408fcbb8e914

the gecko profile task fails.

Investigate and fix the issue

Comment 1

[Florin Strugariu [:Bebe]]

Anyone knows why this is failing?

Comment 2

[Florin Strugariu [:Bebe]]

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=tp6%2C-p&revision=d73cfe3a04e90b5dff64f6d4e3c3a9183aec4ec5

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I see the following in the log:

[taskcluster:error] TASK FAIL since the task payload is invalid. See errors:
[taskcluster:error] - command.2: Invalid type. Expected: array, given: string
[taskcluster:error] Validation of payload failed for task TWqXAHQTQo6I062lKpEgVw

The payload for the failing task can be seen at https://tools.taskcluster.net/groups/AjcF6mSBSxOxhmrOtP5pgg/tasks/TWqXAHQTQo6I062lKpEgVw/details. It looks like the issue is with the value of the "command", where an array is expected, but the string "--geckoProfile" is found. I suspect this string needs to be appended to the array that it follows.

"command": [
  [
    "chmod",
    "+x",
    "run-task"
  ],
  [
    "/usr/local/bin/python3",
    "run-task",
    "--",
    "/usr/local/bin/python2",
    "-u",
    "mozharness/scripts/raptor_script.py",
    "--cfg",
    "mozharness/configs/raptor/mac_config.py",
    "--test=raptor-tp6-1",
    "--download-symbols",
    "ondemand"
  ],
  "--geckoProfile"
],

Comment 4

[Ionuț Goldan [:igoldan]]

Tracking this down, it seems like the logic for applying that extra --geckoProfile resides in this gecko_profile.py module from mozilla-central.

Comment 5

[Ionuț Goldan [:igoldan]]

I've chosen this push range to test the "Create Gecko Profiles" functionality.

I've requested Gecko profiles for T(o)(pageload), T(g1) (pageload), T(c) (startup) jobs, on all desktop platforms.

Looks like Talos is broken too. Not sure in what proportion.

Comment 6

[Ionuț Goldan [:igoldan]]

Also requested Gecko profiles for Rap(tp6-1), Rap(tp6m-c-1), Rap(sp).

Also, I've submitted an initial fix here, on Try. It allows me to inspect the breakage more precisely.

Comment 8

[Ionuț Goldan [:igoldan]]

Attachment: Bug 1594330 - Fix GeckoProfile callback action

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1936d7a01173
Fix GeckoProfile callback action r=jmaher

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1936d7a01173